Review main Merged

21498[BUGFIX] Web->Page - Language view not usable

Stefan Galinski CR +2 V +2 Easy +9 −3 updated 07/04/13, 18:27

Commit message

Since the "all language" elements are displayed in each
language (introduced in 4.7), the language view of the
page module is not really usable anymore. If you have
activated the mod.web_layout.defLangBinding setting in the
Page TS configuration  "all language" elements are not
displayed anymore. Also you cannot overwrite "all language"
elements in an easy way inside another languages
and overwritten elements are displayed together with their
"all language" default element inside a column. Furthermore
the sorting order is sometimes broken on non-default languages
if the "all language" element is rendered inside the column.
The patch fixes all this issues in the languages view by
reverting the changes introduced the 4.7 branch just for the
languages view. The columns view works like it was intented with
the fix from the 4.7 branch (it still has the same flaws as
the languages view, but this issues can be fixed with another
changeset).

Review

  • Code review CR +2
    • Markus Klein +2
    • Ingo Pfennigstorf +1
  • Verified V +2
    • Markus Klein +2
    • Ingo Pfennigstorf +1

Files 1

Review log 13

  1. Mr. Jenkins commented on patch set 1 06/18/13, 15:34

  2. Markus Klein commented on patch set 1 CR -1 06/18/13, 20:24

    Sorry I don't understand from the commit message what the patch actually does. The message only states what is NOT fixed, which is useless in a commit message.
  3. Stefan Galinski commented on patch set 1 06/18/13, 20:34

    The patch fixes the described issues more or less and doesn't lists unfixed issues. I thought this would be clear. Just try it out! :-) The commit message can still be changed later on.
  4. Philipp Gampe commented on patch set 1 06/18/13, 22:52

    @Stefan, you can edit the commit message directly via the edit icon on the top-left. Please describe what the patch does, as this is the most important information in the commit message.
  5. Philipp Gampe commented on patch set 1 06/18/13, 22:58

    Can you add detailed testing instructions to the forge ticket. I could verify the "all language" is displayed in all columns, but what is the defLangBinding?
  6. Stefan Galinski commented on patch set 1 06/19/13, 10:00

    Hi Philipp, You can test the issue by setting the Page TS configuration setting "mod.web_layout.defLangBinding" to "1". Afterwards you shouldn't see any "all language" elements in the languages view anymore. All the other broken stuff is already described in the changeset description. Note that the languages view must work without the defLangBinding setting too and the columns view should still show "all language" elements as this was the intented and broken patchset that was introduced in a 4.7 patchlevel release. The patch itself reverts this changes with small additions for the languages view only as this didn't make sense here. I hope this explanation helps. The changeset description will be changed very slightly in a few moments to indiicate that the patchset fixes this issues and not just lists them (strange that this can be assumed ;-).
  7. Stefan Galinski commented on patch set 1 06/19/13, 10:04

    Documentation of the setting (search for defLangBinding): http://docs.typo3.org/typo3cms/TSconfigReference/PageTsconfig/Mod/Index.html
  8. Stefan Galinski updated the commit message in patch set 1 06/19/13, 10:08

  9. Mr. Jenkins commented on patch set 2 06/19/13, 10:08

  10. Ingo Pfennigstorf voted on patch set 2 V +1 CR +1 07/04/13, 15:43

  11. Ingo Pfennigstorf commented on patch set 2 07/04/13, 15:43

    Verified in TYPO3 6.1
  12. Markus Klein commented on patch set 2 V +2 CR +2 07/04/13, 18:27

    Tested on 6.2
  13. Markus Klein merged patch set 3 07/04/13, 18:27