Review main Merged

21556[TASK] Fix usage of functions, which are deprecated in PHP 5.5

Markus Klein CR +2 V +2 Easy +7 −1 updated 07/15/13, 08:05

Commit message

Fixes a call to preg_replace with /e modifier,
which is deprecated in PHP 5.5 now.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 17

  1. Mr. Jenkins commented on patch set 1 06/20/13, 23:56

  2. Chris topher updated the commit message in patch set 1 06/21/13, 13:15

  3. Mr. Jenkins commented on patch set 2 06/21/13, 13:16

  4. Christian Kuhn commented on patch set 2 06/21/13, 15:10

    Add a unit test to show the substitution is ok before and after the patch?
  5. Markus Klein commented on patch set 2 06/21/13, 17:15

    Thanks for fixing this. It was too late tonight ;-) But I guess I like the thought of PHP 5.5 being deprecated right at the release. *lol*
  6. Chris topher commented on patch set 2 06/21/13, 18:22

    Reply

    You're welcome. :-)
  7. Stefan Neufeind voted on patch set 2 CR +1 06/30/13, 12:10

  8. Markus Klein commented on patch set 2 CR -2 07/13/13, 14:47

    As indicated by Christian: Unit tests missing
  9. Markus Klein uploaded patch set 3 07/13/13, 17:25

  10. Markus Klein commented on patch set 3 CR 0 07/13/13, 17:26

    Now working. Unittest is green again.
  11. Mr. Jenkins commented on patch set 3 07/13/13, 17:27

  12. Christian Kuhn commented on patch set 3 CR -1 07/14/13, 11:38

    Method substUrlsInPlainText is partly covered by tests, but not this part: Commenting out the regex doesn't make tests fail (because the dataProvider always sets 1 as $urlmode parameter). I'd suggest to add tests that trigger this regex code part to see if it works before and after change.
  13. Markus Klein commented on patch set 3 07/14/13, 20:25

    ??? What the heck? $urlmode = 1 should trigger the RegExp. Or am I unable to understand that code??
  14. Christian Kuhn commented on patch set 3 V +1 CR +1 07/14/13, 21:24

    Ah, sry Markus, my bad. You are perfectly right. Tested again, reviewed, patch is fine.
  15. Stefan Neufeind commented on patch set 3 V +2 CR +2 07/15/13, 08:05

    Works fine on 5.5
  16. Stefan Neufeind merged patch set 4 07/15/13, 08:05

  17. Stefan Neufeind commented on patch set 4 07/15/13, 08:05

    Cherry Picked This patchset was cherry picked to change: I6bd4b57d64801be912e0050772420a684b1aa237