Review main Merged

21575[TASK] Remove redundant try/catches in ResourceStorage of FAL

Claus Due CR +2 V +2 Normal +28 −44 updated 07/16/13, 21:54

Commit message

This change simply removes some try/catch statement which did
nothing but re-throw the RuntimeException.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Ingo Pfennigstorf +1
    • Philipp Gampe +1
  • Verified V +2
    • Markus Klein +2
    • Ingo Pfennigstorf +1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 06/21/13, 19:15

  2. Claus Due uploaded patch set 2 06/21/13, 19:16

  3. Mr. Jenkins commented on patch set 2 CR -1 V -1 06/21/13, 19:17

  4. Claus Due uploaded patch set 3 06/21/13, 19:17

  5. Mr. Jenkins commented on patch set 3 CR -1 V -1 06/21/13, 19:18

  6. Claus Due uploaded patch set 4 06/21/13, 19:19

  7. Mr. Jenkins commented on patch set 4 06/21/13, 19:20

  8. Wouter Wolters commented on patch set 4 CR +1 06/21/13, 19:56

    Indeed this looks reasonable. Will give it a test tomorrow.
  9. Philipp Gampe commented on patch set 4 CR +1 06/21/13, 22:28

    who the hack wrote that?
  10. Markus Klein commented on patch set 4 06/22/13, 09:23

    I guess this was done to have another "origin" of the exception.
  11. Wouter Wolters commented on patch set 4 07/16/13, 19:28

    *ping*
  12. Ingo Pfennigstorf commented on patch set 4 V +1 CR +1 07/16/13, 19:36

    Unit tests ok, Patch makes sense
  13. Markus Klein voted on patch set 4 V +2 CR +2 07/16/13, 21:54

  14. Markus Klein merged patch set 5 07/16/13, 21:54

  15. Markus Klein commented on patch set 5 07/16/13, 21:54

    Cherry Picked This patchset was cherry picked to change: I2c1e2f5947071ec5aadb897b4ca1044231552ed8