Review main Merged

21592[BUGFIX] Invisible icon blocks mousefocus of non-required inputfields

Zbigniew Jacko CR +2 V +2 Easy +6 −1 updated 06/23/13, 12:24

Commit message

Set z-index for clear.gif, so a backend user can select the text
inside input fields. Now it's also possible to set focus on the
input field by clicking at the beginning of it.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Files 1

Review log 20

  1. Mr. Jenkins commented on patch set 1 06/22/13, 14:18

  2. Zbigniew Jacko commented on patch set 1 06/22/13, 14:31

    Tested in IE8 Windows, Firefox 21 Windows, Chrome 25
  3. Philipp Gampe commented on patch set 1 V +1 CR +1 06/22/13, 15:30

    Tested with Chrome on Linux
  4. Christian Kuhn updated the commit message in patch set 1 06/22/13, 22:58

  5. Mr. Jenkins commented on patch set 2 06/22/13, 22:59

  6. Christian Kuhn commented on patch set 2 V +1 06/22/13, 23:01

    +1 on testing, works for me in master with chrome. Please let Felix have a look and do not merge before he had a chance to comment.

    element_tceforms.css:543

    maybe a comment to tell what this is for, mentioning the issue number, too?
  7. Felix Kopp commented on patch set 2 06/22/13, 23:02

    (I would like to have a look at this patch)
  8. Philipp Gampe commented on patch set 2 V +1 CR +1 06/22/13, 23:04

    waiting for Felix
  9. Anja Leichsenring commented on patch set 2 V +1 CR +1 06/23/13, 08:15

    join the waiting party ;)
  10. Felix Kopp commented on patch set 2 V +1 06/23/13, 08:47

    Works as expected but the selector changes all clear.gif. I would like to limit the use to FormEngine table. Perhaps like .typo3-TCEforms img[src*="clear.gif"] { } or even .typo3-TCEforms .formField-field img[src*="clear.gif"] { }
  11. Philipp Gampe uploaded patch set 3 06/23/13, 09:29

  12. Mr. Jenkins commented on patch set 3 06/23/13, 09:30

  13. Philipp Gampe commented on patch set 3 V +1 CR +1 06/23/13, 10:10

    Tested with Chrome, IE 10, Opera.
  14. Anja Leichsenring voted on patch set 3 V +1 CR +1 06/23/13, 11:24

  15. Christian Kuhn commented on patch set 3 06/23/13, 12:17

    imho not critical enough for 4.7 & 4.5. lets leave those out and merge to 6.0 - 6.2 only to lower the risk of a possible regression in 4.7 & 4.5 for older browsers.
  16. Christian Kuhn uploaded patch set 4 06/23/13, 12:21

  17. Mr. Jenkins commented on patch set 4 06/23/13, 12:21

  18. Christian Kuhn commented on patch set 4 V +1 CR +1 06/23/13, 12:21

    removed 4.7 & 4.5 from version list, tested again, looks good to me.
  19. Wouter Wolters commented on patch set 4 V +2 CR +2 06/23/13, 12:24

    Taking previous votes into account.
  20. Wouter Wolters merged patch set 5 06/23/13, 12:24