21592[BUGFIX] Invisible icon blocks mousefocus of non-required inputfields
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Files 1
Review log 20
-
Mr. Jenkins commented on patch set 1 06/22/13, 14:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9160/ : SUCCESS -
Zbigniew Jacko commented on patch set 1 06/22/13, 14:31
Tested in IE8 Windows, Firefox 21 Windows, Chrome 25 -
Philipp Gampe commented on patch set 1 V +1 CR +1 06/22/13, 15:30
Tested with Chrome on Linux -
Christian Kuhn updated the commit message in patch set 1 06/22/13, 22:58
-
Mr. Jenkins commented on patch set 2 06/22/13, 22:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9176/ : SUCCESS -
Christian Kuhn commented on patch set 2 V +1 06/22/13, 23:01
+1 on testing, works for me in master with chrome. Please let Felix have a look and do not merge before he had a chance to comment.element_tceforms.css:543maybe a comment to tell what this is for, mentioning the issue number, too? -
Felix Kopp commented on patch set 2 06/22/13, 23:02
(I would like to have a look at this patch) -
Philipp Gampe commented on patch set 2 V +1 CR +1 06/22/13, 23:04
waiting for Felix -
Anja Leichsenring commented on patch set 2 V +1 CR +1 06/23/13, 08:15
join the waiting party ;) -
Felix Kopp commented on patch set 2 V +1 06/23/13, 08:47
Works as expected but the selector changes all clear.gif. I would like to limit the use to FormEngine table. Perhaps like .typo3-TCEforms img[src*="clear.gif"] { } or even .typo3-TCEforms .formField-field img[src*="clear.gif"] { } -
Philipp Gampe uploaded patch set 3 06/23/13, 09:29
-
Mr. Jenkins commented on patch set 3 06/23/13, 09:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9180/ : SUCCESS -
Philipp Gampe commented on patch set 3 V +1 CR +1 06/23/13, 10:10
Tested with Chrome, IE 10, Opera. -
Anja Leichsenring voted on patch set 3 V +1 CR +1 06/23/13, 11:24
-
Christian Kuhn commented on patch set 3 06/23/13, 12:17
imho not critical enough for 4.7 & 4.5. lets leave those out and merge to 6.0 - 6.2 only to lower the risk of a possible regression in 4.7 & 4.5 for older browsers. -
Christian Kuhn uploaded patch set 4 06/23/13, 12:21
-
Mr. Jenkins commented on patch set 4 06/23/13, 12:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9187/ : SUCCESS -
Christian Kuhn commented on patch set 4 V +1 CR +1 06/23/13, 12:21
removed 4.7 & 4.5 from version list, tested again, looks good to me. -
Wouter Wolters commented on patch set 4 V +2 CR +2 06/23/13, 12:24
Taking previous votes into account. -
Wouter Wolters merged patch set 5 06/23/13, 12:24