Review main Merged

21593[FEATURE] Increase size of be_groups table subgroup field

Krzysztof Adamczyk CR +2 V +2 Easy +1 −1 updated 06/22/13, 22:38

Commit message

Change field subgroup from varchar(255) to text to allow
storing more subgroups.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Christian Kuhn +1
  • Verified V +2
    • Philipp Gampe +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 06/22/13, 14:50

  2. Wouter Wolters commented on patch set 1 06/22/13, 14:54

    We are used to have the first word between [] to be upprecasr, so always like BUGFIX, TASK, FEATURE
    Begin a sentence with uppercase. and remove the double space after subgroups
  3. Krzysztof Adamczyk uploaded patch set 2 06/22/13, 15:10

  4. Mr. Jenkins commented on patch set 2 06/22/13, 15:11

  5. Wouter Wolters commented on patch set 2 CR +1 06/22/13, 15:13

    Testing will follow soon, working on another patchset first.
  6. Anja Leichsenring commented on patch set 2 V +1 06/22/13, 17:38

    still a typo, sorry for nitpick. It is subgroups.
  7. Christian Kuhn uploaded patch set 3 06/22/13, 22:12

  8. Mr. Jenkins commented on patch set 3 06/22/13, 22:13

  9. Christian Kuhn uploaded patch set 4 06/22/13, 22:14

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 06/22/13, 22:15

  11. Mr. Jenkins commented on patch set 4 06/22/13, 22:15

  12. Philipp Gampe commented on patch set 4 V +1 CR +1 06/22/13, 22:35

    nobrainer
  13. Philipp Gampe voted on patch set 4 V +2 CR +2 06/22/13, 22:38

  14. Philipp Gampe merged patch set 5 06/22/13, 22:38