Review main Merged

21621[FEATURE] Wizard to add OpenID to backend user

Christian Weiske CR +2 V +2 Hard +391 −2 updated 10/21/13, 06:01

Commit message

Adds an OpenID wizard button to the be_user's tx_openid_openid field.

The wizard allows to enter an OpenID URL, processes the OpenID login
and finally sets the OpenID in the backend user edit form and
backend user settings form.

This helps registering OpenIDs of providers that hand out different
claimed OpenID URLs for each domain, like Google does.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Helmut Hummel +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Fabien Udriot +1
    • Philipp Gampe +1

Issues 1

Files 8

Review log 56

Show 31 earlier messages
  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 06/23/13, 19:16

  2. Christian Weiske uploaded patch set 2 06/23/13, 21:21

  3. Mr. Jenkins commented on patch set 2 06/23/13, 21:22

  4. Philipp Gampe commented on patch set 2 V -1 CR -1 06/23/13, 22:11

    index.php:6

    we never do this! This allows remote file inclusion.
  5. Philipp Gampe commented on patch set 2 06/23/13, 22:33

    I can confirm that the basic functionality works. I would like to get rid of that index.php if possible. However I am now sure of we have a central dispatcher for wizards. Anyway your code contains a security issues. There it cannot go in like this (never ever include something from global scope). Also I think that the wizard for the backend users table is of little use. We should add it to the users settings module too. To do so, we have to switch the field type to users and user a custom function to render to html. Then we can add the wizard icon and link. We will also need to add more CSH to describe the new feature. We should ask our UX/UI guys (Felix?) whether is makes sense to always display a info flash message about what can be done with this field. I fear that most users do not know what openid is.

    Wizard.php:68

    is there really no API method for this

    Wizard.php:94

    Those texts need to go into xlf files, to handle translations; also below

    Wizard.php:99

    IMHO no need for a variable here, use $this->claimedId directly

    Wizard.php:154

    you can use the Fluid view for the full content, not just for the inner html
  6. Philipp Gampe commented on patch set 2 06/23/13, 22:34

    I have no time to work in this today. Maybe tomorrow. Anyway, good start, but we are no there yet.

    Wizard.php:134

    IMHO this method can be merged into the above one.
  7. Christian Weiske uploaded patch set 3 06/24/13, 06:31

  8. Christian Weiske commented on patch set 2 06/24/13, 06:31

    Wizard.php:99 Reply

    Done

    Wizard.php:134 Reply

    Done

    Wizard.php:154 Reply

    Do you have an example where a fluid view is used like that in the backend? The problem that needs to be tackled is including all the default CSS and JS.

    index.php:6 Reply

    Done
  9. Mr. Jenkins commented on patch set 3 06/24/13, 06:32

  10. Christian Weiske commented on patch set 3 06/24/13, 06:32

    I am working on the rest, but wanted to get a first version out ASAP.
  11. Philipp Gampe commented on patch set 3 06/24/13, 07:32

    Take a look at the aboutmodules sysext. You need a layout and a backendcontainer. For the rest, I will need to take a look myself — maybe tonight.
  12. Christian Weiske uploaded patch set 4 06/25/13, 07:57

  13. Mr. Jenkins commented on patch set 4 06/25/13, 07:58

  14. Philipp Gampe commented on patch set 4 V +1 CR -1 06/25/13, 11:51

    ok, I already see the finish line ;) Thanks for your work on this. The functionality works fine already, now we just need to polish it a bit, before we can merge it.

    OpenidModuleSetup.php:66

    LL and you could also use the API to get the icon.

    Wizard.php:94

    url encoded this

    Wizard.php:179

    htmlspecialchar (or inside the template)

    Content.html:37

    LL

    Content.html:40

    LL

    index.php:5

    do you really need those four lines above? otherwise just drop them

    index.php:9

    AFAIK E_NOTICE is already excluded from normal TYPO3 error handling and reporting. Did you test this? Otherwise please drop this line too.
  15. Christian Weiske commented on patch set 4 06/25/13, 19:54

    OpenidModuleSetup.php:66 Reply

    ExtUtility's icon method doesn't return a usable path relative to the document root, so I kept it as it is now. LL done.

    Wizard.php:94 Reply

    Done

    Wizard.php:179 Reply

    Fluid automatically escapes variables.

    Content.html:37 Reply

    Done

    Content.html:40 Reply

    Done

    index.php:5 Reply

    MCONF not, but MOD_PATH and BACK_PATH are needed.

    index.php:9 Reply

    Removed.
  16. Christian Weiske uploaded patch set 5 06/25/13, 19:54

  17. Mr. Jenkins commented on patch set 5 06/25/13, 19:55

  18. Philipp Gampe voted on patch set 5 V +1 CR +1 06/26/13, 17:32

  19. Wouter Wolters commented on patch set 5 CR -1 06/26/13, 17:53

    Some inline comments added.

    Wizard.php:36

    missing proprty type phpDoc

    Wizard.php:37

    missing proprty type phpDoc

    Wizard.php:39

    missing phpDoc for the function

    Wizard.php:58

    Since 6.0 the tabs are not intended with one more extra tab but are on the same level as the code. Please also add an space after the // This holds for every comment in this class.

    Wizard.php:161

    old classname, please refer to the namespaced class.
  20. Christian Weiske uploaded patch set 6 06/26/13, 19:32

  21. Christian Weiske commented on patch set 5 06/26/13, 19:33

    Wizard.php:36 Reply

    Done

    Wizard.php:37 Reply

    Done

    Wizard.php:39 Reply

    Done

    Wizard.php:58 Reply

    I changed it, but the TYPO3 PHPCS standard tells me otherwise (both "TYPO3v4" and "TYPO3").

    Wizard.php:161 Reply

    Done
  22. Mr. Jenkins commented on patch set 6 06/26/13, 19:33

  23. Philipp Gampe voted on patch set 6 V +1 CR +1 06/26/13, 21:29

  24. Soren Malling commented on patch set 6 V -1 CR -1 07/09/13, 09:31

    After using the wizard, the identifier field is filled - but not saved upon saving the TCEform
  25. Christian Weiske uploaded patch set 7 07/09/13, 21:59

  26. Mr. Jenkins commented on patch set 7 07/09/13, 22:01

  27. Christian Weiske uploaded patch set 8 08/10/13, 13:05

  28. Mr. Jenkins commented on patch set 8 08/10/13, 13:05

  29. Philipp Gampe uploaded patch set 9 08/17/13, 17:11

  30. Philipp Gampe commented on patch set 9 08/17/13, 17:11

    rebased
  31. Mr. Jenkins commented on patch set 9 08/17/13, 17:12

  1. Philipp Gampe uploaded patch set 10 08/17/13, 17:15

  2. Mr. Jenkins commented on patch set 10 08/17/13, 17:16

  3. Philipp Gampe commented on patch set 10 V +1 08/17/13, 17:21

    Fixed the icon for the input field (relative path instead of absolute url). I would prefer if the CSS is moved to an own CSS file if possible. Please take a look at typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php to figure out how to create a "normal" backend layout. Or you do some extra work and rewrite this (again) to a fluid template approach. I do not give a minus one, as it works and at lot of time wa s already invested into this.
  4. Fabien Udriot voted on patch set 10 V +1 09/19/13, 08:04

  5. Christian Weiske uploaded patch set 11 09/20/13, 09:16

  6. Christian Weiske commented on patch set 11 09/20/13, 09:16

    Moved CSS into separate file.
  7. Mr. Jenkins commented on patch set 11 09/20/13, 09:26

  8. Fabien Udriot voted on patch set 11 V +1 CR +1 09/20/13, 09:58

  9. Philipp Gampe commented on patch set 11 V +2 CR +2 09/21/13, 16:56

    Basic functionality works. Further cleanups can be done with smaller patches. Tested with Google: https://www.google.com/accounts/o8/id
  10. Frans Saris voted on patch set 11 V +1 CR +1 10/11/13, 18:41

  11. Helmut Hummel commented on patch set 11 10/14/13, 19:14

    I talked to Ernesto about that and he made a really good point, that editing user records is a task for Admins. No editor would be able to use this wizard to get his or her OpenID identity
  12. Helmut Hummel commented on patch set 11 10/14/13, 19:18

    ah, no, the wizard is part of the user setup also

    index.php:24

    that header call must be removed
  13. Helmut Hummel uploaded patch set 12 10/14/13, 19:21

  14. Helmut Hummel commented on patch set 12 10/14/13, 19:31

    Hm, code is there but I do not see the open ID field in user settings so I cannot test
  15. Mr. Jenkins commented on patch set 12 10/14/13, 20:07

  16. Philipp Gampe commented on patch set 12 10/14/13, 23:12

  17. Philipp Gampe voted on patch set 12 V +1 CR +1 10/14/13, 23:21

  18. Helmut Hummel commented on patch set 12 CR +1 10/15/13, 22:30

    Could not test but I would be in favor of adding this to beta2
  19. Fabien Udriot voted on patch set 12 V +1 10/16/13, 07:49

  20. Stefan Neufeind commented on patch set 12 V +2 CR +2 10/17/13, 08:38

    I also didn't have the openid-field in the user-settings at first, just in the backend-user-listing edit-form. Moving the openid-module to the bottom of PackageStates.php made it work for me. After that I was also able to login with that account etc. Wizard works for me.
  21. Stefan Neufeind merged patch set 13 10/17/13, 08:38

  22. Ernesto Baschny commented on patch set 13 10/18/13, 13:52

    Can someone please explain to be what's the use-case for this "Wizard"? I understand what it does, but this is then only useful for an Admin to configure *his own* OpenID. Not for an users / editors. Not for an admin setting up an user. To me this concept is somehow limited and people might have different expectations from it. Other than that, I am disapointed that this was merged after feature freeze without my approval. I have a list of issues that might candidate as "exceptions", and we have to priorize what's important and what's not. This might also set some bad precedents or rise expectations from others that are also insisting that "their cool feature" is vital for inclusion in 6.2. Helmut was so kind to ask for my approval, but I was not able to answer to that yet due to this priorization that I have still to finish. I won't revert this just yet, because it might turn out that it's cool to have it in beta2, but please keep that in mind in the next period!
  23. Stefan Neufeind commented on patch set 13 10/18/13, 14:03

    The feature is also present in the "User settings", so it's also available to normal users. It might be that this setting doesn't show up there for you immediately - we had that during testing, which was due to a package-loading-order thing. But when that part is correct it's also in the user-settings and not just in the user-admin-module. About FF: Well, this is on the list in notes for review before FF. And that list was neither empty nor closed or whatever. So I expected it was agreed from you this was already planned to still go in. And to be honest, I didn't know *sigh* about the release until yesterday afternoon when we talked about it on the chan (I missed have missed something there - but since the email was also missing, I didn't catch that news somehow). But the main point was that it was (still) on the list in the notes.
  24. Ernesto Baschny commented on patch set 13 10/20/13, 11:59

    Indeed I don't see it in my "User Settings" and as I could not find any code that might add it there, I was under the impression this was not included. If this has been considered, I don't argue it's usefulness anymore, of course. And if this bug is related to the PackageManagement "loading order", this must be fixed before beta2. Other than that, I understand you missing beta1 notification, I forgot indeed the mail to the mailing list. So let's go on with this. I'll write more about the "feature freeze" and potential exceptions for 6.2 next week. Thanks for all involved here!
  25. Christian Weiske commented on patch set 13 10/21/13, 06:01

    With the merge of https://review.typo3.org/24852 the OpenID button field shows up now.