Review TYPO3_6-0 Merged

21727[BUGFIX] Wrong placement of image caption in text with image

Stefan Neufeind CR +2 V +2 Easy +4 −5 updated 06/29/13, 12:43

Commit message

If you omit the first caption, then the following captions are shifted
into this position, meaning the the captions are off by the number of
empty captions in front.

This happens because the captions are stored with a newline "\n" as
separator which is removed by a trim = 1.

Remove this trim from tt_content.image.20.caption.1.1 as the trimming of
the actual content happens with
tt_content.image.20.caption.1.stdWrap.trim = 1.

The change also has a few cleanups that popped up in PhpStorm while
investigation the issue.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 2

Review log 2

  1. Stefan Neufeind voted on patch set 1 V +2 CR +2 06/29/13, 12:43

  2. Stefan Neufeind merged patch set 2 06/29/13, 12:43