21748[TASK] CGL, switch(): Indent "case" correctly; no "break" in default
Commit message
Review
-
Code review CR +2
- Markus Klein +2
-
Verified V +2
- Markus Klein +2
Issues 1
Files 122
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php+0 −1
- typo3/sysext/backend/Classes/Controller/Wizard/FormsController.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php+43 −43
- typo3/sysext/backend/Classes/Form/DataPreprocessor.php+122 −122
- typo3/sysext/backend/Classes/Form/FormEngine.php+473 −477
- typo3/sysext/backend/Classes/History/RecordHistory.php+33 −33
- typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php+8 −8
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+48 −49
- typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem.php+57 −57
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+219 −223
- typo3/sysext/backend/Classes/Utility/IconUtility.php+43 −44
- typo3/sysext/backend/Classes/View/PageLayoutView.php+165 −169
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+20 −21
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+87 −90
- typo3/sysext/core/Classes/Cache/CacheManager.php+66 −66
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+109 −109
- typo3/sysext/core/Classes/Collection/RecordCollectionRepository.php+5 −5
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+234 −235
- typo3/sysext/core/Classes/Controller/CommandLineController.php+23 −24
- typo3/sysext/core/Classes/Database/DatabaseConnection.php+0 −1
Show 102 more files
- typo3/sysext/core/Classes/Database/PreparedStatement.php+43 −43
- typo3/sysext/core/Classes/Database/QueryGenerator.php+186 −191
- typo3/sysext/core/Classes/Database/QueryView.php+152 −157
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+67 −67
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+153 −155
- typo3/sysext/core/Classes/Database/SqlParser.php+201 −203
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+307 −312
- typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php+5 −5
- typo3/sysext/core/Classes/Error/ErrorHandler.php+10 −11
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php+9 −9
- typo3/sysext/core/Classes/Html/HtmlParser.php+45 −45
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+251 −252
- typo3/sysext/core/Classes/Http/Observer/Download.php+15 −15
- typo3/sysext/core/Classes/Http/AjaxRequestHandler.php+13 −13
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+270 −273
- typo3/sysext/core/Classes/Locking/Locker.php+92 −92
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+9 −10
- typo3/sysext/core/Classes/Mail/SwiftMailerAdapter.php+0 −1
- typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php+0 −2
- typo3/sysext/core/Classes/Page/PageRenderer.php+47 −48
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+8 −8
- typo3/sysext/core/Classes/Resource/AbstractFile.php+18 −18
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+8 −8
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+32 −32
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+83 −84
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+239 −242
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+27 −27
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+40 −42
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+311 −315
- typo3/sysext/core/Classes/Utility/VersionNumberUtility.php+12 −12
- typo3/sysext/dbal/Classes/Controller/ModuleController.php+211 −212
- typo3/sysext/dbal/Classes/Database/DatabaseConnection.php+945 −949
- typo3/sysext/dbal/Classes/Database/SqlParser.php+416 −424
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/PropertyType.php+6 −8
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+0 −1
- typo3/sysext/extensionmanager/Classes/Utility/Parser/ExtensionXmlPullParser.php+61 −61
- typo3/sysext/extensionmanager/Classes/Utility/Parser/ExtensionXmlPushParser.php+65 −65
- typo3/sysext/extensionmanager/Classes/Utility/Parser/MirrorXmlPullParser.php+29 −29
- typo3/sysext/extensionmanager/Classes/Utility/Parser/MirrorXmlPushParser.php+31 −31
- typo3/sysext/filelist/Classes/FileList.php+0 −2
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php+23 −23
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+31 −31
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+411 −414
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+196 −199
- typo3/sysext/frontend/Classes/ContentObject/FormContentObject.php+231 −233
- typo3/sysext/frontend/Classes/ContentObject/ImageTextContentObject.php+43 −43
- typo3/sysext/frontend/Classes/ContentObject/MediaContentObject.php+52 −52
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+121 −129
- typo3/sysext/frontend/Classes/Hooks/TreelistCacheUpdateHooks.php+36 −36
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+174 −175
- typo3/sysext/frontend/Classes/Page/FramesetRenderer.php+11 −11
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+86 −86
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+0 −1
- typo3/sysext/impexp/Classes/ImportExport.php+48 −50
- typo3/sysext/indexed_search/Classes/Controller/IndexedPagesController.php+135 −138
- typo3/sysext/indexed_search/Classes/Controller/ModuleController.php+14 −14
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+29 −30
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+186 −192
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+114 −118
- typo3/sysext/indexed_search/Classes/Example/CrawlerHook.php+61 −61
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+99 −101
- typo3/sysext/indexed_search/Classes/Hook/MysqlFulltextIndexHook.php+35 −35
- typo3/sysext/indexed_search/Classes/Utility/DoubleMetaPhoneUtility.php+607 −607
- typo3/sysext/indexed_search/Classes/FileContentParser.php+403 −404
- typo3/sysext/info_pagetsconfig/Classes/Controller/InfoPageTyposcriptConfigController.php+0 −1
- typo3/sysext/install/Classes/CoreUpdates/MediaFlexformUpdate.php+8 −8
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+12 −12
- typo3/sysext/linkvalidator/Classes/Linktype/LinkHandler.php+8 −9
- typo3/sysext/lowlevel/Classes/View/ConfigurationView.php+52 −53
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+24 −26
- typo3/sysext/lowlevel/Classes/AdminCommand.php+22 −23
- typo3/sysext/lowlevel/Classes/CleanerCommand.php+36 −40
- typo3/sysext/perm/Classes/Controller/PermissionAjaxController.php+44 −44
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+198 −199
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+41 −41
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+31 −32
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+117 −118
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+41 −42
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+5 −6
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+6 −4
- typo3/sysext/reports/Classes/Report/Status/SystemStatus.php+7 −5
- typo3/sysext/rtehtmlarea/Classes/Controller/SpellCheckingController.php+11 −14
- typo3/sysext/rtehtmlarea/Classes/Extension/MicroDataSchema.php+37 −35
- typo3/sysext/rtehtmlarea/Classes/Hook/SoftReferenceHook.php+5 −6
- typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php+182 −183
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php+30 −31
- typo3/sysext/rtehtmlarea/Classes/SelectImage.php+142 −144
- typo3/sysext/rtehtmlarea/Classes/User.php+17 −20
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+27 −27
- typo3/sysext/saltedpasswords/Classes/Autoloader.php+5 −5
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+38 −39
- typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php+17 −17
- typo3/sysext/sv/Classes/AuthenticationService.php+15 −15
- typo3/sysext/sv/Classes/LoginFormHook.php+11 −11
- typo3/sysext/t3editor/Classes/Hook/TypoScriptTemplateInfoHook.php+7 −7
- typo3/sysext/t3editor/Classes/T3Editor.php+75 −75
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+83 −81
- typo3/sysext/workspaces/Classes/ExtDirect/ActionHandler.php+16 −17
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+47 −43
- typo3/sysext/workspaces/Classes/Service/StagesService.php+66 −70
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+9 −9
Review log 11
-
Mr. Jenkins commented on patch set 1 06/30/13, 14:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9270/ : SUCCESS -
Georg Ringer commented on patch set 1 CR -1 07/01/13, 11:51
really only 6.2 for such cgl issues -
Christian Kuhn commented on patch set 1 07/01/13, 14:02
Reply
yeah, 6.2 only, please. -
Stefan Neufeind uploaded patch set 2 07/01/13, 14:05
-
Stefan Neufeind commented on patch set 2 07/01/13, 14:06
just updated commit-msg to 6.2-only (by popular demand) -
Mr. Jenkins commented on patch set 2 07/01/13, 14:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9283/ : SUCCESS -
Stefan Neufeind uploaded patch set 3 07/06/13, 10:25
-
Stefan Neufeind commented on patch set 3 07/06/13, 10:26
rebased. and took care of a few more cases. -
Mr. Jenkins commented on patch set 3 07/06/13, 10:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9441/ : SUCCESS -
Markus Klein voted on patch set 3 V +2 CR +2 07/06/13, 11:51
-
Wouter Wolters merged patch set 4 07/06/13, 13:19