Review main Merged

21759[TASK] Adds fileReferenceUid to content rendering

Lars Malach CR +2 V +2 Easy +6 −3 updated 07/27/13, 16:07

Commit message

FrontendContentAdapterService saves the file uid but not the
file reference uid.

This commits adds the file reference uid.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • Lars Malach +1
    • Andreas Wolf +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 10

  1. Mr. Jenkins commented on patch set 1 07/01/13, 09:35

  2. Andreas Wolf uploaded patch set 2 07/02/13, 16:20

  3. Andreas Wolf voted on patch set 2 CR +1 07/02/13, 16:20

  4. Mr. Jenkins commented on patch set 2 07/02/13, 16:21

  5. Lars Malach voted on patch set 2 CR +1 07/03/13, 05:33

  6. Steffen Ritter voted on patch set 2 CR +2 07/06/13, 22:05

  7. Stefan Neufeind voted on patch set 2 CR +1 07/08/13, 12:10

  8. Markus Klein commented on patch set 2 V +1 CR +1 07/13/13, 14:10

    I don't know how to test that, but just adding information shouldn't hurt too much. Therefore also v+1
  9. Wouter Wolters voted on patch set 2 V +2 CR +2 07/27/13, 16:07

  10. Wouter Wolters merged patch set 3 07/27/13, 16:07