Review main Merged

21760[BUGFIX] EM: Scheduler task does not persist to database

Wouter Wolters CR +2 V +2 Easy +41 −1 updated 07/02/13, 11:28

Commit message

The scheduler task for updating extension list of the extension
manager does not persist his data to database. As Scheduler is no
extbase extension and the task is no extbase task this peristence
isn't called at end of script.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 12

  1. Mr. Jenkins commented on patch set 1 07/01/13, 11:51

  2. Alexander Opitz commented on patch set 1 V -1 07/01/13, 23:03

    The problem isn't solved with this patch. $repository->setLastUpdate(new \DateTime()); is called in TYPO3\CMS\Extensionmanager\Domain\Repository\RepositoryRepository::updateRepositoryCount() through TYPO3\CMS\Extensionmanager\Utility\Importer\ExtensionListUtility::import() The problem is the missing persistAll() call as Scheduler isn't an Extbase extension.
  3. Alexander Opitz uploaded patch set 2 07/01/13, 23:12

  4. Mr. Jenkins commented on patch set 2 07/01/13, 23:13

  5. Christian Kuhn commented on patch set 2 CR +1 07/02/13, 07:42

    +1 on reading, sounds logical. will give it a test soon.
  6. Christian Kuhn commented on patch set 2 V -1 07/02/13, 09:59

    issue is confirmed to be fixed, but a unit test fails now.
  7. Christian Kuhn uploaded patch set 3 07/02/13, 10:10

  8. Mr. Jenkins commented on patch set 3 07/02/13, 10:11

  9. Christian Kuhn commented on patch set 3 V +1 CR +1 07/02/13, 10:12

    Adapted the existing test to the method change, added a new test to check if persistAll is called.
  10. Alexander Opitz commented on patch set 3 07/02/13, 10:15

    UpdateExtensionListTaskTest.php:81

    Shouldn't we add ->with('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Persistenc eManager') here?
  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 07/02/13, 11:28

  12. Anja Leichsenring merged patch set 4 07/02/13, 11:28