21760[BUGFIX] EM: Scheduler task does not persist to database
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 12
-
Mr. Jenkins commented on patch set 1 07/01/13, 11:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9279/ : SUCCESS -
Alexander Opitz commented on patch set 1 V -1 07/01/13, 23:03
The problem isn't solved with this patch. $repository->setLastUpdate(new \DateTime()); is called in TYPO3\CMS\Extensionmanager\Domain\Repository\RepositoryRepository::updateRepositoryCount() through TYPO3\CMS\Extensionmanager\Utility\Importer\ExtensionListUtility::import() The problem is the missing persistAll() call as Scheduler isn't an Extbase extension. -
Alexander Opitz uploaded patch set 2 07/01/13, 23:12
-
Mr. Jenkins commented on patch set 2 07/01/13, 23:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9288/ : SUCCESS -
Christian Kuhn commented on patch set 2 CR +1 07/02/13, 07:42
+1 on reading, sounds logical. will give it a test soon. -
Christian Kuhn commented on patch set 2 V -1 07/02/13, 09:59
issue is confirmed to be fixed, but a unit test fails now. -
Christian Kuhn uploaded patch set 3 07/02/13, 10:10
-
Mr. Jenkins commented on patch set 3 07/02/13, 10:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9294/ : SUCCESS -
Christian Kuhn commented on patch set 3 V +1 CR +1 07/02/13, 10:12
Adapted the existing test to the method change, added a new test to check if persistAll is called. -
Alexander Opitz commented on patch set 3 07/02/13, 10:15
UpdateExtensionListTaskTest.php:81Shouldn't we add ->with('TYPO3\\CMS\\Extbase\\Persistence\\Generic\\Persistenc eManager') here? -
Anja Leichsenring voted on patch set 3 V +2 CR +2 07/02/13, 11:28
-
Anja Leichsenring merged patch set 4 07/02/13, 11:28