Review TYPO3_4-5 Merged

21776[BUGFIX] Check if TER dump exists before modify time check

Jigal van Hemert CR +2 V +2 Easy +4 −4 updated 09/20/14, 15:57

Commit message

The modify time of the extensions.xml.gz file is used to display the last
update of the extension list. Checking if the file exists will prevent a
PHP warning.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 1

Review log 9

  1. Alexander Opitz voted on patch set 1 CR +1 07/05/13, 13:08

  2. Philipp Gampe commented on patch set 1 CR -1 07/17/13, 08:53

    index.php:2463

    @file_exists; otherwise the function produces an E_WARNING
  3. Alexander Opitz commented on patch set 1 07/17/13, 13:41

    index.php:2463 Reply

    Why hiding problems on filesystem, which we can't handle? E_WARNING is only emited upon failure, not if the file wasn't found.
  4. Oliver Hader commented on patch set 1 CR +2 09/20/14, 15:43

    index.php:2463 Reply

    Why? file_exists('file.is.not.there') does not trigger a warning...
  5. Oliver Hader updated the commit message in patch set 2 09/20/14, 15:43

  6. Oliver Hader voted on patch set 2 CR +2 09/20/14, 15:43

  7. Oliver Hader rebased onto patch set 2 09/20/14, 15:50

  8. Oliver Hader voted on patch set 3 CR +2 V +2 09/20/14, 15:57

  9. Oliver Hader merged patch set 3 09/20/14, 15:57