Review main Merged

21818[TASK] Remove usage of property $new_unique_uid

Georg Ringer CR +2 V +2 Easy +10 −27 updated 12/13/14, 17:42

Commit message

The property $this->new_unique_uid in PageLayoutController
is never used. Some very strange and dead code can be
just removed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 12

  1. Mr. Jenkins commented on patch set 1 07/02/13, 17:54

  2. Susi Moog voted on patch set 1 V +1 CR +1 07/02/13, 18:12

  3. Wouter Wolters commented on patch set 1 CR -1 07/02/13, 19:23

    PageLayoutController.php:685

    needs to be unset also??

    PageLayoutController.php:765

    still needed here? new_unique_uid

    PageLayoutController.php:1008

    new_unique_uid still needed here?

    PageLayoutController.php:1114

    new_unique_uid still needed here?
  4. Wouter Wolters uploaded patch set 2 12/13/14, 13:49

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 12/13/14, 13:53

  6. Christian Kuhn commented on patch set 2 CR +2 V +2 12/13/14, 14:14

    I tested quite some stuff in quick edit mode and could not find any change in behavior ... looks good to me.
  7. Christian Kuhn merged patch set 2 12/13/14, 14:14

  8. Helmut Hummel commented on patch set 3 12/13/14, 14:32

    post -1 on this one, too

    PageLayoutController.php:783

    $new_unique_uid is set here and was used below (which was removed with this change) Are you sure we did not kill some functionality that might be useful? At least it is not true that the property was not used (like stated in the commit message). It *was* used and now it is removed without removal of all traces and without clearly stating which functionality is gone.

    PageLayoutController.php:824

    $new_unique_uid var is created above and not removed
  9. Christian Kuhn commented on patch set 3 12/13/14, 14:48

    PageLayoutController.php:783 Reply

    yes, i've seen that, too. assigning $new_unique_uid to $rec['uid'] seems legit and should stay. For the rest, I tried hard to find any functional change in quick edit behavior, but did not find anything. did you?
  10. Helmut Hummel commented on patch set 3 12/13/14, 15:20

    PageLayoutController.php:673

    @Christian: there was no functional change, because this query always failed, as the NEWid is currently too small (varchar(20)) to hold the uniquid string (26 chars)

    PageLayoutController.php:674

    if that bug would be fixed, then this $edit_record will be set here, which obviously triggers a different code path below. How this affects the quick edit behavior for users? I have no idea. But I would not just remove code, without understanding the complete impact. That's all from my side. I will not investigate further.
  11. Christian Kuhn commented on patch set 3 12/13/14, 17:41

    Ok, thanks Helmut. I'm not sure about the impact of this change anymore, too. So lets revert this one.
  12. Christian Kuhn commented on patch set 3 12/13/14, 17:42

    Reverted This patchset was reverted in change: I4291a6ff4b06b74fb9fb5e757fc738f8bd413ca5