21819[TASK] Replace inject methods with @inject; allow @Flow\Inject
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Alexander Schnitzler +1
-
Verified V +2
- Stefan Neufeind +2
- Alexander Schnitzler +1
Issues 1
Files 84
- typo3/sysext/extbase/Classes/Command/HelpCommandController.php+1 −8
- typo3/sysext/extbase/Classes/Configuration/AbstractConfigurationManager.php+3 −24
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+4 −10
- typo3/sysext/extbase/Classes/Configuration/ConfigurationManager.php+2 −16
- typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php+1 −8
- typo3/sysext/extbase/Classes/Mvc/Cli/Command.php+3 −16
- typo3/sysext/extbase/Classes/Mvc/Cli/CommandManager.php+1 −8
- typo3/sysext/extbase/Classes/Mvc/Cli/Request.php+1 −8
- typo3/sysext/extbase/Classes/Mvc/Cli/RequestBuilder.php+3 −24
- typo3/sysext/extbase/Classes/Mvc/Cli/RequestHandler.php+4 −32
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php+3 −30
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+3 −23
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php+7 −62
- typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php+1 −10
- typo3/sysext/extbase/Classes/Mvc/Controller/CommandController.php+1 −8
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerContext.php+3 −21
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php+1 −9
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+3 −24
- typo3/sysext/extbase/Classes/Mvc/Web/AbstractRequestHandler.php+4 −32
- typo3/sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php+2 −16
Show 64 more files
- typo3/sysext/extbase/Classes/Mvc/Web/Request.php+3 −24
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+4 −33
- typo3/sysext/extbase/Classes/Mvc/Web/Response.php+1 −9
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+2 −19
- typo3/sysext/extbase/Classes/Mvc/RequestHandlerResolver.php+3 −30
- typo3/sysext/extbase/Classes/Object/Container/ClassInfoFactory.php+1 −1
- typo3/sysext/extbase/Classes/Object/Container/Container.php+1 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+4 −33
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+7 −67
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/QueryObjectModelFactory.php+1 −8
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+5 −41
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+6 −53
- typo3/sysext/extbase/Classes/Persistence/Generic/IdentityMap.php+1 −7
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+1 −10
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+1 −10
- typo3/sysext/extbase/Classes/Persistence/Generic/PersistenceManager.php+3 −30
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+4 −38
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryFactory.php+3 −23
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryResult.php+2 −20
- typo3/sysext/extbase/Classes/Persistence/Generic/Session.php+1 −10
- typo3/sysext/extbase/Classes/Persistence/Repository.php+8 −43
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileCollectionConverter.php+1 −7
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileFolderConverter.php+1 −7
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractTypeConverter.php+1 −9
- typo3/sysext/extbase/Classes/Property/Mapper.php+5 −40
- typo3/sysext/extbase/Classes/Property/PropertyMapper.php+2 −16
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+1 −8
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php+2 −16
- typo3/sysext/extbase/Classes/Scheduler/TaskExecutor.php+3 −21
- typo3/sysext/extbase/Classes/Security/Channel/RequestHashService.php+1 −8
- typo3/sysext/extbase/Classes/Service/ExtensionService.php+2 −16
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+2 −20
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Configuration/BackendConfigurationManagerTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Core/BootstrapTest.php+4 −5
- typo3/sysext/extbase/Tests/Unit/Mvc/Cli/CommandManagerTest.php+5 −4
- typo3/sysext/extbase/Tests/Unit/Mvc/Cli/CommandTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/Cli/RequestBuilderTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Mvc/Cli/RequestTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+15 −15
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentBehaviorBeforeExtbase14Test.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentsTest.php+10 −10
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentTest.php+8 −7
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/RequestBuilderTest.php+32 −32
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+7 −6
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+32 −30
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+9 −9
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+9 −8
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/MapperTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Scheduler/FieldProviderTest.php+9 −9
- typo3/sysext/extbase/Tests/Unit/Scheduler/TaskExecuterTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php+11 −11
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetControllerTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php+15 −15
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/ViewHelperBaseTestcase.php+1 −1
Review log 29
Show 4 earlier messages
-
Mr. Jenkins commented on patch set 1 07/02/13, 18:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9321/ : SUCCESS -
Alexander Schnitzler commented on patch set 1 CR -2 07/02/13, 18:35
Breaks fluid unit tests. -
Stefan Neufeind uploaded patch set 2 07/02/13, 23:54
-
Mr. Jenkins commented on patch set 2 07/02/13, 23:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9326/ : SUCCESS
-
Stefan Neufeind commented on patch set 2 07/02/13, 23:56
@Alex: Please try again. Fixed fluid-testcases, which broke due to mocking and manual injections. Adjustments in AbstractWidgetControllerTest.php (1 line) and FormViewHelperTest.php (4x 1 line). -
Alexander Schnitzler uploaded patch set 3 07/03/13, 09:40
-
Mr. Jenkins commented on patch set 3 07/03/13, 09:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9330/ : SUCCESS -
Alexander Schnitzler commented on patch set 3 07/03/13, 09:41
This ist the travis build of exactly this commit: https://travis-ci.org/alexanderschnitzler/TYPO3-Sandbox/builds/8689727 -
Alexander Schnitzler rebased onto patch set 3 07/03/13, 09:44
-
Mr. Jenkins commented on patch set 4 07/03/13, 09:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9331/ : SUCCESS -
Markus Günther commented on patch set 4 07/04/13, 15:39
One stupid question.... why we use Flow\inject as anotation and not only inject? I think it looks weird. -
Alexander Schnitzler commented on patch set 4 07/04/13, 20:06
I think that we should adjust our code to the one of Flow as much as possible. If poeple are going to port their Extbase Extensions to Flow they have to change the @inject to @Flow\Inject anyway. My last patch introduced the possibility to use @Flow\Inject in Extbase extensions, so people can now go on and yet use this annotation. As the users can do this I think Extbase should be the prototype for all extensions. Therefore Extbase itself should use the new annotations. If someone somewhen looks into the Extbase code itself he is encouraged to use Flow\Inject. Imho the simple @inject has always been wrong and as soon as I backported the annotation parser of Flow I would like to remove the @validate annotations as well. -
Anja Leichsenring uploaded patch set 5 07/05/13, 16:28
-
Mr. Jenkins commented on patch set 5 07/05/13, 16:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9413/ : SUCCESS -
Anja Leichsenring uploaded patch set 6 07/05/13, 16:36
-
Mr. Jenkins commented on patch set 6 07/05/13, 16:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9417/ : SUCCESS -
Anja Leichsenring commented on patch set 6 V -1 07/05/13, 16:40
three failing unit tests after resolving a conflict (that showed no conflicts). Please ignore patchset 5 -
Alexander Schnitzler uploaded patch set 7 07/05/13, 20:35
-
Alexander Schnitzler commented on patch set 7 07/05/13, 20:35
-
Mr. Jenkins commented on patch set 7 07/05/13, 20:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9426/ : SUCCESS -
Marc Bastian Heinrichs commented on patch set 7 07/05/13, 20:51
needs to be adapted too thenneeds to be adapted too then -
Stefan Neufeind uploaded patch set 8 07/05/13, 21:08
-
Mr. Jenkins commented on patch set 8 07/05/13, 21:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9429/ : SUCCESS -
Stefan Neufeind commented on patch set 8 07/05/13, 21:09
adjust commit-msg keep optional @Flow\Inject (got "messed up" during a search-replace I guess) -
Alexander Schnitzler commented on patch set 8 07/06/13, 08:17
Yeah, thanks a lot! -
Alexander Schnitzler commented on patch set 8 V +1 CR +1 07/06/13, 09:16
-
Stefan Neufeind commented on patch set 8 V +2 CR +2 07/06/13, 10:37
Has been discussed several times now. We should put this to an end. -
Stefan Neufeind merged patch set 9 07/06/13, 10:37
-
Marc Bastian Heinrichs commented on patch set 9 07/06/13, 11:22
Reverted This patchset was reverted in change: I2113b5320f2a6f5dd56cfa7b06469fa1628d2645