21827[TASK] Implement LoggerInterface from PSR-3
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Markus Klein +1
- Wouter Wolters +1
- Christian Kuhn +1
- Helmut Hummel +1
-
Verified V +2
- Georg Ringer +2
- Helmut Hummel +1
Issues 1
Files 4
Review log 16
-
Mr. Jenkins commented on patch set 1 07/02/13, 23:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9325/ : SUCCESS -
Steffen Müller commented on patch set 1 07/02/13, 23:14
To be honest, I am unsure if it's worth the hassle. Adding an interface within a file in contrib and loading it via require_once() because of autoloader limitation looks quite hacky to me. -
Steffen Müller commented on patch set 1 07/02/13, 23:18
The same hacky require() stuff would be needed to resolve http://forge.typo3.org/issues/48876 -
Markus Klein voted on patch set 1 CR +1 07/03/13, 07:32
-
Christian Kuhn commented on patch set 1 07/03/13, 07:39
Hmm, i don't care too much about the require actually. We are doing similar things with eg. swiftmailer. Even if we move those contrib/ we would just have to adjust the require, so that would be ok from my pov. -
Georg Ringer voted on patch set 1 V +1 CR +1 07/03/13, 07:48
-
Steffen Müller commented on patch set 1 07/03/13, 08:03
require calls are expensive and cost performance, in our case without gaining anything (even if it's just 1ms, it's wasted). Technically it has no effect, weather we implement the interface or not. We're anyhow 100% compatible with it. I pushed this change request in order to discuss this topic here having some code in front of us. So please don't merge, even if we have enough votes. Alterntively we could put the interface to Classes/Log/LoggerInterface and use core namespace (and autoloader). But then we'd have to fiddle around with the license. However the interface is sooooo simple, so I doubt it has sufficient originality to claim copyright on it at all. (my personal opinion, IANAL) -
Helmut Hummel uploaded patch set 2 07/03/13, 15:11
-
Mr. Jenkins commented on patch set 2 07/03/13, 15:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9345/ : SUCCESS -
Helmut Hummel commented on patch set 2 V +1 CR +1 07/03/13, 15:21
For the records: It makes a huge difference in terms of interchangeability of loggers if our logger implements the interface or not. Ideally all classes using a logger should only depend on the PSR LoggerInterface, so that *any* logger implementation could be injected into these classes. So +1 letting the logger implement the interface. I would however stay away from require calls and use the autoloader registry instead as suggested with this patchset. -
Wouter Wolters voted on patch set 2 CR +1 07/03/13, 15:42
-
Steffen Müller commented on patch set 2 07/03/13, 18:21
perfect! -
Markus Klein voted on patch set 2 CR +1 07/03/13, 18:57
-
Christian Kuhn voted on patch set 2 CR +1 07/03/13, 23:22
-
Georg Ringer voted on patch set 2 V +2 CR +2 07/04/13, 07:17
-
Georg Ringer merged patch set 3 07/04/13, 07:17