Review main Merged

21855[BUGFIX] Followup for removed table wrap in FormEngine

Benni Mack CR +2 V +2 Easy +5 −1 updated 05/28/14, 07:58

Commit message

The previous issue #49596, ChangeID
Ifa46ce40ff4437b2bb3e7d32e5e4e56caba0caec
brings a side-effect that TCEform record editing for records
without tabs have no background at all.

The attached patch fixes that by adding a wrap around the
whole form (but not  for inline editing records).

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 07/03/13, 16:29

  2. Georg Ringer voted on patch set 1 V +2 CR +2 07/04/13, 07:19

  3. Georg Ringer merged patch set 2 07/04/13, 07:19

  4. Thomas Maroschik commented on patch set 2 01/23/14, 15:46

    FormEngine.php:896

    I think this condition doesn't make sense. It prevents just the rendering of the background when some inline elements are present. Should we remove it?
  5. Markus Klein commented on patch set 2 01/23/14, 21:23

    FormEngine.php:896 Reply

    Tom: Am I right that you're referring actually to the "regression" you mentioned on IRC?
  6. Thomas Maroschik commented on patch set 2 01/24/14, 08:08

    FormEngine.php:896 Reply

    Exactly. I think the intention was to prevent rendering of the wrapper div in irre forms, but as far as I could see this happens somewhere else.
  7. Frans Saris commented on patch set 2 05/28/14, 07:37

    FormEngine.php:896 Reply

    This line should indeed be removed. Is there already a issue in forge for this?
  8. Frans Saris commented on patch set 2 05/28/14, 07:58