21855[BUGFIX] Followup for removed table wrap in FormEngine
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
-
Verified V +2
- Georg Ringer +2
Issues 1
Files 1
Review log 8
-
Mr. Jenkins commented on patch set 1 07/03/13, 16:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9346/ : SUCCESS -
Georg Ringer voted on patch set 1 V +2 CR +2 07/04/13, 07:19
-
Georg Ringer merged patch set 2 07/04/13, 07:19
-
Thomas Maroschik commented on patch set 2 01/23/14, 15:46
FormEngine.php:896I think this condition doesn't make sense. It prevents just the rendering of the background when some inline elements are present. Should we remove it? -
Markus Klein commented on patch set 2 01/23/14, 21:23
FormEngine.php:896ReplyTom: Am I right that you're referring actually to the "regression" you mentioned on IRC? -
Thomas Maroschik commented on patch set 2 01/24/14, 08:08
FormEngine.php:896ReplyExactly. I think the intention was to prevent rendering of the wrapper div in irre forms, but as far as I could see this happens somewhere else. -
Frans Saris commented on patch set 2 05/28/14, 07:37
FormEngine.php:896ReplyThis line should indeed be removed. Is there already a issue in forge for this? -
Frans Saris commented on patch set 2 05/28/14, 07:58
created new issue http://forge.typo3.org/issues/59163