Review main Merged

21963[BUGFIX] Category API does not consider multiple tables

Markus Klein CR +2 V +2 Easy +8 −1 updated 07/16/13, 20:59

Commit message

Using the Category API with multiple tables, leads to wrong
results due to a missing check for the correct table.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 13

  1. Mr. Jenkins commented on patch set 1 07/05/13, 16:24

  2. Markus Klein commented on patch set 1 07/05/13, 16:25

    Maybe a unit test would be helpful, but don't know how to...
  3. Steffen Ritter voted on patch set 1 V +1 CR +1 07/06/13, 08:28

  4. Georg Ringer voted on patch set 1 CR +1 07/06/13, 11:52

  5. Stefan Neufeind voted on patch set 1 CR +1 07/06/13, 14:19

  6. Christian Kuhn uploaded patch set 2 07/06/13, 15:38

  7. Mr. Jenkins commented on patch set 2 07/06/13, 15:39

  8. Stefan Neufeind voted on patch set 2 CR +1 07/06/13, 16:33

  9. Wouter Wolters voted on patch set 2 V +1 CR +1 07/16/13, 18:47

  10. Stefan Neufeind commented on patch set 2 V +2 CR +2 07/16/13, 20:57

    tested with a slightly modified version of the already existing function tests (yes, we should add a functional test for this sometime soon)
  11. Stefan Neufeind merged patch set 3 07/16/13, 20:57

  12. Stefan Neufeind commented on patch set 3 07/16/13, 20:58

    Cherry Picked This patchset was cherry picked to change: Iaf5b453acd434ab8d8f58932a2c96385a66abf37
  13. Stefan Neufeind commented on patch set 3 07/16/13, 20:59

    Cherry Picked This patchset was cherry picked to change: Iaf5b453acd434ab8d8f58932a2c96385a66abf37