Review main Merged

21979[BUGFIX] Wrong result on empty string globalString condition

Marc Bastian Heinrichs CR +2 V +2 Easy +29 −1 updated 02/01/14, 22:30

Commit message

A TypoScript condition like
"[globalString = GP:anEmptyGetPostVarKey = ]" returns a false
value instead of the expected true value.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Philipp Gampe +1

Files 3

Review log 9

  1. Mr. Jenkins commented on patch set 1 07/05/13, 21:47

  2. Philipp Gampe commented on patch set 1 V +1 CR +1 07/07/13, 11:39

    not sure about 4.5 branch, is the code same?
  3. Philipp Gampe commented on patch set 1 CR -1 07/07/13, 11:43

    IMHO the unit test should be done for the abstractConditionMatcher and not inside other unit tests. (getAbstractMoch?!?) ping me if you need help with this
  4. Marc Bastian Heinrichs commented on patch set 1 02/01/14, 17:36

    Till now we have no abstract accessible mocks. Patch is here https://review.typo3.org/#/c/25315/ That's because I added the tests to the frontend and backend classes, how this is done for all the other tests for functions from the abstract class.
  5. Philipp Gampe commented on patch set 1 CR +1 02/01/14, 21:31

    ok then
  6. Stefan Neufeind voted on patch set 1 V +2 CR +2 02/01/14, 22:29

  7. Stefan Neufeind merged patch set 2 02/01/14, 22:29

  8. Stefan Neufeind commented on patch set 2 02/01/14, 22:30

    Cherry Picked This patchset was cherry picked to change: I114b702f4b5ae5f68236874325e82974a8ba6107
  9. Stefan Neufeind commented on patch set 2 02/01/14, 22:30

    Cherry Picked This patchset was cherry picked to change: I114b702f4b5ae5f68236874325e82974a8ba6107