21979[BUGFIX] Wrong result on empty string globalString condition
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Philipp Gampe +1
-
Verified V +2
- Stefan Neufeind +2
- Philipp Gampe +1
Files 3
- typo3/sysext/backend/Tests/Unit/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+13 −0
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+3 −1
- typo3/sysext/frontend/Tests/Unit/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+13 −0
Review log 9
-
Mr. Jenkins commented on patch set 1 07/05/13, 21:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9433/ : SUCCESS -
Philipp Gampe commented on patch set 1 V +1 CR +1 07/07/13, 11:39
not sure about 4.5 branch, is the code same? -
Philipp Gampe commented on patch set 1 CR -1 07/07/13, 11:43
IMHO the unit test should be done for the abstractConditionMatcher and not inside other unit tests. (getAbstractMoch?!?) ping me if you need help with this -
Marc Bastian Heinrichs commented on patch set 1 02/01/14, 17:36
Till now we have no abstract accessible mocks. Patch is here https://review.typo3.org/#/c/25315/ That's because I added the tests to the frontend and backend classes, how this is done for all the other tests for functions from the abstract class. -
Philipp Gampe commented on patch set 1 CR +1 02/01/14, 21:31
ok then -
Stefan Neufeind voted on patch set 1 V +2 CR +2 02/01/14, 22:29
-
Stefan Neufeind merged patch set 2 02/01/14, 22:29
-
Stefan Neufeind commented on patch set 2 02/01/14, 22:30
Cherry Picked This patchset was cherry picked to change: I114b702f4b5ae5f68236874325e82974a8ba6107 -
Stefan Neufeind commented on patch set 2 02/01/14, 22:30
Cherry Picked This patchset was cherry picked to change: I114b702f4b5ae5f68236874325e82974a8ba6107