Review main Merged

21984[BUGFIX] Fixed return URL in reports module

Tim Spiekerkötter CR +2 V +2 Easy +1 −1 updated 07/06/13, 10:44

Commit message

Added urlencode to the returnUrl in the getAdminAccountStatus method.

Review

  • Code review CR +2
    • Felix Kopp +2
    • Wouter Wolters +1
    • Tim Lochmüller +1
  • Verified V +2
    • Felix Kopp +2
    • Wouter Wolters +1
    • Tim Lochmüller +1

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 07/05/13, 22:12

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 07/06/13, 09:27

  3. Tim Lochmüller voted on patch set 1 V +1 CR +1 07/06/13, 10:02

  4. Felix Kopp commented on patch set 1 V +2 CR +2 07/06/13, 10:37

    Hi Tim, thank you for the patchset! Works great. Please do not vote on your own patchset unless the patch was change by someone else drastically. Votes are sufficient thought based on Wouters and my vote. I will merge right now
  5. Felix Kopp merged patch set 2 07/06/13, 10:37

  6. Tim Lochmüller commented on patch set 2 07/06/13, 10:44

    Hey Flexi. Thanks for merge... Firstname is Tim - thats right - but the owner is a other Tim ;)
  7. Tim Lochmüller commented on patch set 2 07/06/13, 10:44

    Flexi = Felix!