Review main Merged

21994[FEATURE] Added autofocus attribute to textfield and textarea

Tim Spiekerkötter CR +2 V +2 Easy +2 −0 updated 08/09/13, 19:03

Commit message

The ViewHelpers f:form.textfield and f:form.textarea were lacking the
HTML5 "autofocus" attribute. It is available for button, input and
textarea. Now Fluid reflects this correctly by adding this attribute to
the initializeArguments methods for TextareaViewHelper and
TextfieldViewHelper.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +2
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 8

  1. Mr. Jenkins commented on patch set 1 07/06/13, 10:46

  2. Stefan Neufeind commented on patch set 1 07/06/13, 10:50

    Could you please verify if this is already in Flow-Fluid (see git-repo)? Or first send a issue+patch there imho so we can handle this here as a backport then.
  3. Tim Spiekerkötter commented on patch set 1 07/06/13, 11:00

    It is not fixed yet. I will try to push this patch to the Fluid Package. Thank you.
  4. Tim Spiekerkötter commented on patch set 1 07/06/13, 11:23

    Okay, here is the issue with patch. http://forge.typo3.org/issues/49726 is there anything else I can do to help with this issue?
  5. Stefan Neufeind commented on patch set 1 07/06/13, 13:41

    You could have set both issues as related on forge and pushed your patch to gerrit instead of adding a patch to forge. I've done so on your behalf now. Review at: https://review.typo3.org/22013
  6. Wouter Wolters commented on patch set 1 V +2 CR +2 08/08/13, 16:55

    This FEATURE has been merged today into TYPO3.Fluid if nobody object I will merged in 48h
  7. Christian Kuhn voted on patch set 1 V +2 CR +2 08/09/13, 19:03

  8. Christian Kuhn merged patch set 2 08/09/13, 19:03