Review main Merged

22004Revert "[TASK] Replace inject methods with @inject; allow @Flow\Inject"

Marc Bastian Heinrichs CR +2 V +2 Expert +1304 −377 updated 07/06/13, 11:24

Commit message

This reverts commit ad7219c2818455edd65918b9a5f8d1b70c0afed7

See https://review.typo3.org/#/c/21997/

More notes on this:
A regex to replace @inject with @Flow\Inject when porting 
Extbase extensions to Flow is very simple and fast.

Additionally @Flow\Inject makes only sense with using "use 
TYPO3\Flow\Annotations as Flow". But with a backported 
annotation parser I expect that we would have annotations 
in "TYPO3\CMS\Extbase\Annotations". Using them as alias 
"Flow" is a bad style as the alias should be "Extbase" then.

Review

  • Code review CR +2
    • Marc Bastian Heinrichs +2
  • Verified V +2
    • Marc Bastian Heinrichs +2

Files 84

Show 64 more files

Review log 3

  1. Mr. Jenkins commented on patch set 1 07/06/13, 11:23

  2. Marc Bastian Heinrichs voted on patch set 1 V +2 CR +2 07/06/13, 11:24

  3. Marc Bastian Heinrichs merged patch set 2 07/06/13, 11:24