Review main Merged

22006[TASK] Replace inject methods with @inject

Marc Bastian Heinrichs CR +2 V +2 Expert +378 −1305 updated 07/08/13, 17:14

Commit message

Currently we are using inject methods like:

/*
 * @param $foo Foo
 */
public function injectFoo(Foo $foo) {
	$this->foo = $foo;
}

This patch removes these methods and introduces
property annotations:

/**
 * @var Foo
 * @inject
 */
protected $foo;

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Alexander Schnitzler +1
    • Marc Bastian Heinrichs +1
  • Verified V +2
    • Anja Leichsenring +2
    • Alexander Schnitzler +1
    • Marc Bastian Heinrichs +1

Issues 1

Files 83

Show 63 more files

Review log 6

  1. Mr. Jenkins commented on patch set 1 07/06/13, 11:43

  2. Alexander Schnitzler commented on patch set 1 V +1 CR +1 07/06/13, 12:16

  3. Marc Bastian Heinrichs voted on patch set 1 V +1 CR +1 07/06/13, 20:33

  4. Stefan Neufeind voted on patch set 1 CR +1 07/08/13, 12:09

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 07/08/13, 17:14

  6. Anja Leichsenring merged patch set 2 07/08/13, 17:14