Review main Merged

22019[BUGIFX] RTEmagic upgrade wizard: missing attributes

Francois Suter CR +2 V +2 Easy +13 −4 updated 07/14/13, 10:00

Commit message

When the RTE creates a magic images it uses data-* attributes
to keep a reference to the original FAL record. The upgrade
wizard migrates the images, creates the sys_file entries but
does not add the data-* attributes.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 07/06/13, 14:37

  2. Wouter Wolters commented on patch set 1 07/06/13, 15:07

    RteMagicImagesUpdateWizard.php:168

    This last space inside the string is then double, could this last one be removed?

    RteMagicImagesUpdateWizard.php:175

    space to much
  3. Francois Suter uploaded patch set 2 07/06/13, 15:23

  4. Francois Suter commented on patch set 2 07/06/13, 15:23

    Removed the extra spaces mentioned in the comments.
  5. Mr. Jenkins commented on patch set 2 07/06/13, 15:25

  6. Wouter Wolters voted on patch set 2 CR +1 07/06/13, 15:26

  7. Francois Suter commented on patch set 2 07/07/13, 12:28

    You don't need a full "ready to upgrade" installation to test this, I have added a test scenario to the Forge issue.
  8. Wouter Wolters commented on patch set 2 V +1 07/08/13, 18:52

    Image shows up correct in RTE and in frontend.
  9. Stefan Neufeind voted on patch set 2 CR +1 07/10/13, 16:13

  10. Markus Klein commented on patch set 2 CR +1 07/13/13, 14:26

    This change now changes the behaviour, such that reference replacement will only take place if the the file is used in an src attribute. Can we be sure, that is this is the only combination where filenames can appear?
  11. Francois Suter commented on patch set 2 07/13/13, 16:21

    This wizard is about magic images and this is the syntax with which magic images are written. So I wouldn't expect side effect.s
  12. Markus Klein voted on patch set 2 V +2 CR +2 07/13/13, 18:32

  13. Markus Klein merged patch set 3 07/13/13, 18:32

  14. Markus Klein commented on patch set 3 07/13/13, 18:32

    Cherry Picked This patchset was cherry picked to change: Ib483355336d1331892920ada847850a61c35a3af
  15. Francois Suter commented on patch set 3 07/14/13, 10:00

    Thanks for taking care.