Review main Abandoned

22023[BUGFIX] admin_get_dbs: Keep the current database selected

Helmut Hummel CR 0 V 0 Easy +5 −0 updated 11/11/13, 14:04

Commit message

admin_get_dbs checks if available databases can be
selected, but does not select the original one before
returning the values.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 9

  1. Mr. Jenkins commented on patch set 1 07/06/13, 15:15

  2. Christian Kuhn updated the commit message in patch set 1 07/06/13, 15:19

  3. Christian Kuhn voted on patch set 2 V +1 CR +1 07/06/13, 15:19

  4. Mr. Jenkins commented on patch set 2 07/06/13, 15:19

  5. Markus Klein commented on patch set 2 CR -1 07/06/13, 15:21

    @christian: no, not ok at all.
  6. Christian Kuhn voted on patch set 2 V 0 CR 0 07/06/13, 15:22

  7. Wouter Wolters commented on patch set 2 CR -1 07/16/13, 18:37

    This one could be abandoned, right?
  8. Markus Klein commented on patch set 2 11/10/13, 11:22

    Helmut, your response/action please.
  9. Helmut Hummel abandoned the change 11/11/13, 14:04

    Yeah, not needed