Review main Merged

22030[BUGFIX] Undefined switchable controller actions must be removed

Alexander Schnitzler CR +2 V +2 Normal +148 −1 updated 07/17/13, 11:36

Commit message

Currently there is no check if switchable controller actions in
pi_flexform are still present in the configuration flexform. So,
when removing the flexforms in the configuration file, the
switchable controller actions section is not deleted in pi_flexform.

This change removes all occurences in the present pi_flexform, so
if no switchable controller actions are defined any longer, they
will be removed, else they are overwritten by the current flexform
data.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 11

  1. Mr. Jenkins commented on patch set 1 07/06/13, 15:54

  2. Alexander Schnitzler rebased onto patch set 1 07/06/13, 16:45

  3. Mr. Jenkins commented on patch set 2 07/06/13, 16:46

  4. Alexander Schnitzler commented on patch set 2 07/06/13, 16:46

  5. Wouter Wolters rebased onto patch set 2 07/16/13, 18:55

  6. Mr. Jenkins commented on patch set 3 07/16/13, 18:56

  7. Wouter Wolters uploaded patch set 4 07/16/13, 18:59

  8. Wouter Wolters voted on patch set 4 V +1 CR +1 07/16/13, 18:59

  9. Mr. Jenkins commented on patch set 4 07/16/13, 19:00

  10. Anja Leichsenring voted on patch set 4 V +2 CR +2 07/17/13, 11:36

  11. Anja Leichsenring merged patch set 5 07/17/13, 11:36