Review main Merged

22063[FEATURE] Improve BE container view helper

Francois Suter CR +2 V +2 Hard +129 −277 updated 07/06/13, 22:07

Commit message

Improve the features provided by the BE container view helper
so that extensions don't need to provide their own so often.
Added features:

- load several JS and CSS files instead of just one
- load jQuery
- load some inline language labels

Note: the old way of loading a single JS and CSS file is preserved
for backwards compatibility, but marked as deprecated.

With this patch all BE modules in the Core can use the default
BE container view helper. The Extension Manager needs some special
initialization which is moved to a dedicated view helper.

The customized BE container view helpers are removed.

Review

  • Code review CR +2
    • Felix Kopp +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Felix Kopp +2
    • Wouter Wolters +1
    • Christian Kuhn +1

Issues 1

Files 8

Review log 5

  1. Mr. Jenkins commented on patch set 1 07/06/13, 20:43

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 07/06/13, 21:14

  3. Christian Kuhn commented on patch set 1 V +1 CR +1 07/06/13, 22:01

    very clean, thank you! Please wait with merge until travis is green again ...
  4. Felix Kopp commented on patch set 1 V +2 CR +2 07/06/13, 22:07

    Cleanliness is next to godliness
  5. Felix Kopp merged patch set 2 07/06/13, 22:07