Review main Merged

22067[FEATURE] FormEngine: Possibility to add icons via pageTSconfig

Benni Mack CR +2 V +2 Normal +65 −8 updated 12/10/14, 20:16

Commit message

If someone adds a new value/label pair for a select field in
TCEforms/FormEngine, it is not possible to also add an icon to
the new option.
Alternatively, existing values can be changed through the new
"altIcons" property that acts like the "altLabels" property.

The patch adds another subelement for TSconfig to also add an
icon, as well as a new property.

TCEFORM.pages.doktype.addItems {
	13 = My Label
	13.icon = sysext/t3skin/icons/gfx/i/pages.gif
}
TCEFORM.pages.doktype.altIcons {
	123 = EXT:myext/icon.gif
}

The icon path must be relative to the typo3/ directory.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Alessandro Bellafronte +1
    • Christoph Dörfel +1
    • Michel Georgy +1
  • Verified V +2
    • Georg Ringer +2
    • Susi Moog +1

Issues 1

Files 6

Review log 24

  1. Mr. Jenkins commented on patch set 1 07/06/13, 20:54

  2. Christoph Dörfel uploaded patch set 2 09/11/13, 19:56

  3. Mr. Jenkins commented on patch set 2 09/11/13, 19:57

  4. Christoph Dörfel voted on patch set 2 V +1 CR +1 09/11/13, 20:03

  5. Christoph Dörfel voted on patch set 2 V 0 CR 0 09/11/13, 20:04

  6. Christoph Dörfel voted on patch set 2 CR +1 09/11/13, 20:05

  7. Michel Georgy voted on patch set 2 V +1 CR +1 09/19/13, 13:38

  8. Alessandro Bellafronte voted on patch set 2 CR +1 09/19/13, 13:38

  9. 4eyes GmbH voted on patch set 2 CR +1 09/19/13, 13:47

  10. Stefan Neufeind voted on patch set 2 V +1 CR +1 10/17/13, 14:50

  11. Stefan Neufeind commented on patch set 2 11/11/13, 17:45

    @Ernesto: This has been standing quite long. Still for 6.2 or not?
  12. Ernesto Baschny commented on patch set 2 CR -1 11/12/13, 15:04

    Cool feature, but we have other priorities yet for 6.2, so no merge please. Sad that it took so long, but there are plenty of other "nice additions" which take long to get in. That's a thing we should work on in future. Hope you understand the decision as we have to draw the line somewhere. Let's make 6.3/7.0 rock with this feature (which will for sure include this new feature).
  13. Benni Mack uploaded patch set 3 09/09/14, 11:07

  14. Anja Leichsenring updated the commit message in patch set 4 09/09/14, 11:33

  15. Anja Leichsenring commented on patch set 4 09/09/14, 11:40

    Feature-35891-AddTCAItemsWithIconsViaPageTSConfig.rst:20

    please keep the hint 'Icon path must be relative to the typo3/ directory'
  16. Benni Mack uploaded patch set 5 10/21/14, 06:09

  17. Alessandro Bellafronte voted on patch set 5 CR +1 10/21/14, 06:25

  18. Christoph Dörfel voted on patch set 5 CR +1 10/21/14, 06:39

  19. Michel Georgy voted on patch set 5 CR +1 10/21/14, 08:00

  20. Benni Mack commented on patch set 5 11/08/14, 14:12

    any tests on this issue would be great!
  21. Benni Mack commented on patch set 5 12/09/14, 12:10

    ping, any tests from anybody?
  22. Susi Moog voted on patch set 5 V +1 12/10/14, 06:36

  23. Georg Ringer voted on patch set 5 CR +2 V +2 12/10/14, 20:16

  24. Georg Ringer merged patch set 5 12/10/14, 20:16