22067[FEATURE] FormEngine: Possibility to add icons via pageTSconfig
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Alessandro Bellafronte +1
- Christoph Dörfel +1
- Michel Georgy +1
-
Verified V +2
- Georg Ringer +2
- Susi Moog +1
Issues 1
Files 6
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php+7 −2
- typo3/sysext/backend/Classes/Form/Element/SelectElement.php+7 −2
- typo3/sysext/backend/Classes/Form/FlexFormsHelper.php+11 −2
- typo3/sysext/backend/Classes/Form/FormEngine.php+16 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-35891-AddTCAItemsWithIconsViaPageTSConfig.rst1new+22 −0
- typo3/sysext/t3editor/res/jslib/parse_typoscript/tokenizetyposcript.js+2 −0
Review log 24
-
Mr. Jenkins commented on patch set 1 07/06/13, 20:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9504/ : SUCCESS -
Christoph Dörfel uploaded patch set 2 09/11/13, 19:56
-
Mr. Jenkins commented on patch set 2 09/11/13, 19:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10638/ : SUCCESS -
Christoph Dörfel voted on patch set 2 V +1 CR +1 09/11/13, 20:03
-
Christoph Dörfel voted on patch set 2 V 0 CR 0 09/11/13, 20:04
-
Christoph Dörfel voted on patch set 2 CR +1 09/11/13, 20:05
-
Michel Georgy voted on patch set 2 V +1 CR +1 09/19/13, 13:38
-
Alessandro Bellafronte voted on patch set 2 CR +1 09/19/13, 13:38
-
4eyes GmbH voted on patch set 2 CR +1 09/19/13, 13:47
-
Stefan Neufeind voted on patch set 2 V +1 CR +1 10/17/13, 14:50
-
Stefan Neufeind commented on patch set 2 11/11/13, 17:45
@Ernesto: This has been standing quite long. Still for 6.2 or not? -
Ernesto Baschny commented on patch set 2 CR -1 11/12/13, 15:04
Cool feature, but we have other priorities yet for 6.2, so no merge please. Sad that it took so long, but there are plenty of other "nice additions" which take long to get in. That's a thing we should work on in future. Hope you understand the decision as we have to draw the line somewhere. Let's make 6.3/7.0 rock with this feature (which will for sure include this new feature). -
Benni Mack uploaded patch set 3 09/09/14, 11:07
-
Anja Leichsenring updated the commit message in patch set 4 09/09/14, 11:33
-
Anja Leichsenring commented on patch set 4 09/09/14, 11:40
Feature-35891-AddTCAItemsWithIconsViaPageTSConfig.rst:20please keep the hint 'Icon path must be relative to the typo3/ directory' -
Benni Mack uploaded patch set 5 10/21/14, 06:09
-
Alessandro Bellafronte voted on patch set 5 CR +1 10/21/14, 06:25
-
Christoph Dörfel voted on patch set 5 CR +1 10/21/14, 06:39
-
Michel Georgy voted on patch set 5 CR +1 10/21/14, 08:00
-
Benni Mack commented on patch set 5 11/08/14, 14:12
any tests on this issue would be great! -
Benni Mack commented on patch set 5 12/09/14, 12:10
ping, any tests from anybody? -
Susi Moog voted on patch set 5 V +1 12/10/14, 06:36
-
Georg Ringer voted on patch set 5 CR +2 V +2 12/10/14, 20:16
-
Georg Ringer merged patch set 5 12/10/14, 20:16