Review main Abandoned

22081[FEATURE] Provide a getText viewhelper

Philipp Gampe CR 0 V 0 Normal +145 −0 updated 05/03/15, 15:04

Commit message

getText is the TypoScript data type behind the
stdWrap.data and stdWrap.dataWrap magic.

Provide a viewhelper to render getText data directly,
without the need to create a TS path for the cObject
viewhelper beforehand.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 07/06/13, 23:08

  2. Christian Kuhn commented on patch set 1 CR -1 07/06/13, 23:42

    Should have unit tests, at least as example how it works.
  3. Christian Kuhn commented on patch set 1 07/06/13, 23:49

    in general, i like this view helper. we could think about moving this one to TypoScript sub-folder, and in a second patch move cObj viewhelper to that folder, too. This would decouple the flow viewhelpers from cms vh at this place. it should be doable i think with the cObj move if we set a class alias map entry i guess (to be checked).
  4. Marc Bastian Heinrichs wrote 10/21/13, 18:20

    Topic updated from "49755" to "fluid".
  5. Felix Kopp commented on patch set 1 12/14/14, 10:58

    Solution still valid or did better approaches arise?
  6. Christian Kuhn commented on patch set 1 12/14/14, 12:14

    not sure anymore whether we need that. there is the general TS lib viewhelper that solves this, too. It may not make much sense to add arbitrary portions of TS magic in view helper anymore. I tend to stay -1, but for different reasons now ;)
  7. Christian Kuhn commented on patch set 1 12/14/14, 12:18

    to be more precise, we have the cObject view helper, so actually getText can not be fetched directly, yet ... still unsure ...
  8. Mathias Brodala commented on patch set 1 12/14/14, 15:38

    I agree with Christian, this one should be <f:typoScript.getText/>. Maybe think about introducing a new namespace instead which would allow putting viewhelpers in other extensions besides fluid?
  9. Philipp Gampe commented on patch set 1 12/14/14, 19:57

    I would still prefer to have all the CMS specific viewhelpers (backend and frontend) in an own extension. I personally would sort them into the backend and frontend extensions, but more specific extensions would be ok too. IMHO it is (and was) wrong to put CMS specific viewhelpers into the fluid extension.
  10. Mathias Schreiber wrote 12/17/14, 12:18

    Topic changed from fluid to EXT: fluid
  11. Philipp Gampe abandoned the change 05/03/15, 15:04

    obviously not much interest in this