Review main Abandoned

22160[FEATURE] Allow to disable the 4th part of the typolink generation

Tim Lochmüller CR 0 V 0 Easy +3 −3 updated 07/17/15, 19:10

Commit message

This patch adds a check to the 4th part of the typolink configuration
to disable this part with a "-" character. This allows more parameters
after the 4th parameter without a strange looking URL generation.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 23

  1. Mr. Jenkins commented on patch set 1 07/09/13, 13:18

  2. Wouter Wolters commented on patch set 1 07/09/13, 13:29

    He Tim, Thanks for the patch. The releases line also contains 6.1, but a FEATURE can only go to current master branch aka 6.2. Wouter
  3. Tim Lochmüller uploaded patch set 2 07/09/13, 13:49

  4. Mr. Jenkins commented on patch set 2 07/09/13, 13:50

  5. Tim Lochmüller commented on patch set 2 07/09/13, 13:50

    Thanks for the note. First patches in the last days... There is much to learn :)
  6. Mathias Schreiber wrote 12/17/14, 20:37

    Topic set to cObj
  7. Stefan Neufeind uploaded patch set 3 12/24/14, 01:12

  8. Stefan Neufeind commented on patch set 3 12/24/14, 01:12

    hand-rebased
  9. Mathias Brodala commented on patch set 3 CR -1 12/24/14, 10:05

    ContentObjectRenderer.php:5850

    This variable name is very likely wrong.
  10. Stefan Neufeind uploaded patch set 4 12/25/14, 17:21

  11. Stefan Neufeind uploaded patch set 5 12/25/14, 17:22

  12. Benni Mack voted on patch set 5 CR +1 12/26/14, 01:09

  13. Benni Mack uploaded patch set 6 12/31/14, 11:55

  14. Benni Mack voted on patch set 6 CR +1 01/01/15, 11:16

  15. Michael Oehlhof voted on patch set 6 CR +1 01/04/15, 00:27

  16. Jigal van Hemert voted on patch set 6 CR +2 V +1 02/01/15, 20:42

  17. Stefan Neufeind voted on patch set 6 CR +1 02/01/15, 22:18

  18. Markus Klein updated the commit message in patch set 7 02/01/15, 23:20

  19. Markus Klein commented on patch set 7 02/01/15, 23:20

    IMO an rst-file makes sense for this feature.
  20. Michael Oehlhof voted on patch set 7 CR +1 02/14/15, 21:35

  21. Markus Klein commented on patch set 7 04/13/15, 21:33

    @Tim: can you please add a feature description. You may use https://forger.typo3.org/standard/rst
  22. Stefan Neufeind commented on patch set 7 CR -1 07/14/15, 23:43

    On current master that lives in the TypoLinkCodecService now and thus needs to be redone. Still needs a discussion how we want to handle that case.
  23. Tim Lochmüller abandoned the change 07/17/15, 19:10

    We do not need this patch anymore. In the current master, the TypoLinkCodecService check the 4. param against static::$emptyValueSymbol ("-"). So the patch is not needed anymore...