Review TYPO3_6-1 Merged

22193[BUGFIX] LocalDriver: Recursive file listing is broken

Stefan Neufeind CR +2 V +2 Hard +255 −24 updated 08/11/13, 18:24

Commit message

The recursive file listing, introduced as part of the public API in
the fix for #43249, is currently broken.

One problem is that the file information retrieval is incomplete: The
filename of files in subfolders also contains the path to this file from
the current folder, while the identifier is missing that information.
The identifier is thus wrong and the filename contains too much
information (more than the filename).

Additionally, the method getDirectoryItemList() returns the file list
with the filenames as key, which will fail when a file name exists twice
in different folders. Therefore, this patch changes the keys to numeric
values when a recursive folder list is requested.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +1

Issues 1

Files 7

Review log 6

  1. Nicole Hummel commented on patch set 1 V +1 CR +1 08/07/13, 13:53

    Nothing broken. Was another patch.
  2. Stefan Neufeind commented on patch set 1 CR +1 08/07/13, 14:31

    looked as well. seems to have been a straight backport imho.
  3. Nicole Hummel uploaded patch set 2 08/07/13, 16:04

  4. Nicole Hummel commented on patch set 2 V +1 CR +1 08/07/13, 16:34

    This patch indeed broke file list on Windows systems. I fixed that issue. In master this is fixed already as well.
  5. Wouter Wolters voted on patch set 2 V +2 CR +2 08/11/13, 18:24

  6. Wouter Wolters merged patch set 3 08/11/13, 18:24