Review main Merged

22282[BUGFIX] Localconf upgrade wizard fails

Wouter Wolters CR +2 V +2 Easy +3 −1 updated 07/15/13, 21:36

Commit message

Converting localconf.php to LocalConfiguration.php
with the installtool upgrade-wizard fails on
Debian Squeeze installation.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 07/13/13, 15:45

  2. Stefan Geith voted on patch set 1 CR +1 07/14/13, 10:24

  3. Susi Moog commented on patch set 1 07/14/13, 10:37

    In general +1 but please add a comment to that line, else the next one working on it will probably inline it again and reintroduce the bug...
  4. Christian Kuhn uploaded patch set 2 07/14/13, 11:50

  5. Christian Kuhn commented on patch set 2 V +1 CR +1 07/14/13, 11:50

    Added a comment, fine with the patch.
  6. Mr. Jenkins commented on patch set 2 07/14/13, 11:50

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 07/15/13, 21:36

  8. Anja Leichsenring merged patch set 3 07/15/13, 21:36