Review main Merged

22346[TASK] Setting space before/after should use !important

Georg Ringer CR +2 V +2 Easy +2 −2 updated 07/16/13, 12:34

Commit message

If the setting space before/after is used, the generated styles
should use !important to override possible CSS styles done somewhere else.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jo Hasenau +1
    • Ralf-Rene Schroeder +1
  • Verified V +2
    • Markus Klein +2
    • Jo Hasenau +1
    • Ralf-Rene Schroeder +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 07/16/13, 05:06

  2. Jo Hasenau commented on patch set 1 V +1 CR -1 07/16/13, 08:02

    Verified with the second "!important" being before the ";". After changing that, I will give a +1 for the code as well ;-)
  3. Ralf-Rene Schroeder commented on patch set 1 07/16/13, 10:45

    also for me: the 'px; !important' has to be: 'px !important;' after this it is for me +1
  4. Georg Ringer uploaded patch set 2 07/16/13, 11:06

  5. Mr. Jenkins commented on patch set 2 07/16/13, 11:07

  6. Ralf-Rene Schroeder commented on patch set 2 V +1 CR +1 07/16/13, 11:20

    OK, it works for me...
  7. Jo Hasenau voted on patch set 2 V +1 CR +1 07/16/13, 11:58

  8. Markus Klein voted on patch set 2 V +2 CR +2 07/16/13, 12:34

  9. Markus Klein merged patch set 3 07/16/13, 12:34

  10. Markus Klein commented on patch set 3 07/16/13, 12:34

    Cherry Picked This patchset was cherry picked to change: Ib2cbef280e6d2ac9d1503448ebaede48cf9d159b
  11. Markus Klein commented on patch set 3 07/16/13, 12:34

    Cherry Picked This patchset was cherry picked to change: Ib2cbef280e6d2ac9d1503448ebaede48cf9d159b