Review main Merged

22381[BUGFIX] Faulty layout if row details are too long

Oliver Hader CR +2 V +2 Easy +6 −2 updated 07/17/13, 17:22

Commit message

If the row details in in the workspaces difference view are too
long, e.g. a string that does not contain white-spaces like e.g.
a filename, the layout looks broken.
The solution is to introduce a new classname for the content
details and to force word breaking via CSS.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Files 2

Review log 7

  1. Mr. Jenkins commented on patch set 1 07/17/13, 11:55

  2. Markus Klein commented on patch set 1 V +1 CR +1 07/17/13, 12:00

  3. Oliver Hader commented on patch set 1 07/17/13, 12:28

    Thanks Markus, I did not test Opera... but the only way around would be to pre-process these strings and insert "break-points"... But I think we can ignore that for now in Opera...
  4. Wouter Wolters commented on patch set 1 V +2 CR +2 07/17/13, 17:21

    Tested on Windows with IE7-IE10, FF and Chrome
  5. Wouter Wolters merged patch set 2 07/17/13, 17:21

  6. Wouter Wolters commented on patch set 2 07/17/13, 17:22

    Cherry Picked This patchset was cherry picked to change: I9a768aed1c9bb4ebdfea5ba79083b7e5dce262d9
  7. Wouter Wolters commented on patch set 2 07/17/13, 17:22

    Cherry Picked This patchset was cherry picked to change: I9a768aed1c9bb4ebdfea5ba79083b7e5dce262d9