Review main Abandoned

22402[BUGFIX] Workspace selector in top toolbar cannot scroll

Oliver Hader CR 0 V 0 Easy +18 −5 updated 07/19/13, 11:17

Commit message

If there are too many workspaces defined, some of them cannot
be accessed using the workspace selector in in the top toolbar
due to a missing scrolling behaviour of that component.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 5

  1. Mr. Jenkins commented on patch set 1 07/18/13, 16:25

  2. Wouter Wolters commented on patch set 1 07/18/13, 16:47

    Please also check https://review.typo3.org/#/c/21912/ which is similar AFAICS now
  3. Oliver Hader commented on patch set 1 07/18/13, 17:04

    Yepp, I've showed my thoughts during the workspaces workshop at the T3DD13... Georg's patch is basically taken from my first draft at https://github.com/ohader/TYPO3.CMS-Workspaces/commit/c395cce5d04071bf9ccce26ffda5f74ced7f6741 :) However, I prefer to use this changeset since it just inserts the scrolling behaviour
  4. Oliver Hader commented on patch set 1 CR -1 07/18/13, 17:27

    Checking the other patch and will see how to combine them...
  5. Oliver Hader abandoned the change 07/19/13, 11:17