22440[BUGFIX] Class loader tries to load classes it cannot load
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
-
Verified V +2
- Stefan Neufeind +2
Issues 1
Files 1
Review log 14
-
Mr. Jenkins commented on patch set 1 07/20/13, 10:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9682/ : SUCCESS -
Philipp Gampe voted on patch set 1 CR +1 07/20/13, 10:42
-
Markus Klein updated the commit message in patch set 1 07/20/13, 10:46
-
Mr. Jenkins commented on patch set 2 07/20/13, 10:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9683/ : SUCCESS -
Markus Klein commented on patch set 2 CR +1 07/20/13, 10:55
How test this with minimum effort? -
Andreas Wolf commented on patch set 2 07/20/13, 11:02
Just try loading a class from a composer package that only has one namespace path. I had a clone of https://github.com/t3node/TYPO3-BDD, executed composer install and included the autoload.php afterwards. Loading some Symfony file failed afterwards. -
Markus Klein voted on patch set 2 V +1 07/22/13, 11:19
-
Stefan Neufeind commented on patch set 2 CR +1 07/25/13, 22:09
Change looks okay to me. Just have a nitpick about your example in the comment.ClassLoader.php:348nitpick: Classname would always be last in this example -
Frans Saris voted on patch set 2 CR +1 07/26/13, 21:06
-
Stefan Neufeind uploaded patch set 3 07/27/13, 20:34
-
Stefan Neufeind commented on patch set 3 V +2 CR +2 07/27/13, 20:35
Only took care of the comment-nitpick. Merging with previous votes. -
Stefan Neufeind merged patch set 4 07/27/13, 20:35
-
Mr. Jenkins commented on patch set 3 07/27/13, 20:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9766/ : SUCCESS -
Stefan Neufeind commented on patch set 4 07/27/13, 20:36
Cherry Picked This patchset was cherry picked to change: I1cd3964b9486ea591fb373533fd6cef4e9ce3989