Review main Abandoned

22529[TASK] Cleanup .htaccess; Remove uneccesary rules

Michiel Roos CR 0 V 0 Easy +7 −10 updated 01/10/14, 14:24

Commit message

Do not rewrite static resources, but serve them
directly. TYPO3 handles the rest of the requests.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 07/24/13, 07:38

  2. Michiel Roos uploaded patch set 2 12/20/13, 08:02

  3. Michiel Roos wrote 12/20/13, 08:02

    Topic set to "performance".
  4. Michiel Roos commented on patch set 2 12/20/13, 08:02

    Updated commit message
  5. Mr. Jenkins commented on patch set 2 12/20/13, 08:15

  6. Xavier Perseguers commented on patch set 2 12/20/13, 09:53

    Invalid format, may probably bug our automatic scripts to get an overview of pending changes => 6.2, 6.1, 4.5
  7. Michiel Roos uploaded patch set 3 12/20/13, 10:02

  8. Mr. Jenkins commented on patch set 3 12/20/13, 10:16

  9. Markus Klein commented on patch set 3 CR -1 12/20/13, 11:22

    change-id should be part of the last paragraph. please ensure you're using the correct commit-msg hook in your git repo
  10. Markus Klein updated the commit message in patch set 3 12/20/13, 11:22

  11. Mr. Jenkins commented on patch set 4 12/20/13, 11:34

  12. Xavier Perseguers voted on patch set 4 CR +1 12/21/13, 14:56

  13. Stefan Neufeind commented on patch set 4 CR -1 12/26/13, 00:55

    I doubt it's faster. And imho it even might introduce a change in behaviour.

    _.htaccess:115

    Is this really an optimisation here? Before the path for several large directories was checked and the request always served as static, no matter what. Now you fully base that on file exists, diretory exists etc. Imho before the checks were more leightweight and caught more general cases (like for example "everything below fileadmin").
  14. Michiel Roos abandoned the change 01/10/14, 14:24

    Stefan is right. I've always seen the extra RewriteRule as an extra set, while in fact is does save time.
  15. Michiel Roos commented on patch set 4 01/10/14, 14:24

    _.htaccess:115 Reply

    Hmm, I've never looked at it that way. Abandoning this patch.