22538[TASK] Use real boolean value for getLL second param
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 25
- typo3/sysext/backend/Classes/Controller/Wizard/ColorpickerController.php+6 −6
- typo3/sysext/backend/Classes/Controller/Wizard/FormsController.php+30 −30
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+14 −14
- typo3/sysext/backend/Classes/Controller/NoDocumentsOpenController.php+3 −3
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+6 −6
- typo3/sysext/backend/Classes/Controller/ShortcutFrameController.php+18 −18
- typo3/sysext/backend/Classes/RecordList/ElementBrowserRecordList.php+2 −2
- typo3/sysext/backend/Classes/View/PageLayoutView.php+4 −4
- typo3/sysext/cshmanual/Classes/Controller/HelpModuleController.php+12 −12
- typo3/sysext/filelist/Classes/FileList.php+2 −2
- typo3/sysext/form/Classes/View/Wizard/WizardView.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php+6 −6
- typo3/sysext/func_wizards/Classes/Controller/WebFunctionWizardsBaseController.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+80 −80
- typo3/sysext/impexp/Classes/ImportExport.php+23 −23
- typo3/sysext/perm/Classes/Controller/PermissionModuleController.php+26 −26
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+31 −31
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
Show 5 more files
- typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php+24 −24
- typo3/sysext/rtehtmlarea/Classes/SelectImage.php+8 −8
- typo3/sysext/rtehtmlarea/Classes/User.php+4 −4
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+2 −2
- typo3/sysext/wizard_sortpages/Classes/View/SortPagesWizardModuleFunction.php+1 −1
Review log 5
-
Mr. Jenkins commented on patch set 1 07/24/13, 14:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9712/ : SUCCESS -
Markus Klein voted on patch set 1 V +1 CR +1 07/24/13, 15:52
-
Stefan Neufeind commented on patch set 1 07/25/13, 22:07
The parts I looked at look okay. It makes sense imho to use the hsc-parameter here. And it might potentially also make a difference security-wise. Found the function getLLL() (three L) would be a candidate as well. Calls not yet replaced here.Multiple functions (from the same field) used getLL() sL() and imho also getLLL() should be used here as well -
Stefan Neufeind voted on patch set 1 V +2 CR +2 07/26/13, 10:20
-
Stefan Neufeind merged patch set 2 07/26/13, 10:20