Review main Merged

22538[TASK] Use real boolean value for getLL second param

Wouter Wolters CR +2 V +2 Hard +309 −309 updated 07/26/13, 10:20

Commit message

Make use of boolean value TRUE as second parameter in
getLL function.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 25

Show 5 more files

Review log 5

  1. Mr. Jenkins commented on patch set 1 07/24/13, 14:43

  2. Markus Klein voted on patch set 1 V +1 CR +1 07/24/13, 15:52

  3. Stefan Neufeind commented on patch set 1 07/25/13, 22:07

    The parts I looked at look okay. It makes sense imho to use the hsc-parameter here. And it might potentially also make a difference security-wise. Found the function getLLL() (three L) would be a candidate as well. Calls not yet replaced here.
    Multiple functions (from the same field) used getLL() sL() and imho also getLLL() should be used here as well
  4. Stefan Neufeind voted on patch set 1 V +2 CR +2 07/26/13, 10:20

  5. Stefan Neufeind merged patch set 2 07/26/13, 10:20