22542[TASK] Use real boolean value for trimExplode third param
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 66
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php+5 −5
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php+2 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −2
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php+3 −3
- typo3/sysext/backend/Classes/Form/DataPreprocessor.php+5 −5
- typo3/sysext/backend/Classes/Form/FormEngine.php+22 −22
- typo3/sysext/backend/Classes/Module/ModuleSettings.php+3 −3
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+3 −3
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+9 −9
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+1 −1
- typo3/sysext/core/Classes/Controller/CommandLineController.php+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php+2 −2
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −1
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+45 −45
- typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php+2 −2
Show 46 more files
- typo3/sysext/core/Classes/Html/HtmlParser.php+11 −11
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+8 −8
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+1 −1
- typo3/sysext/core/Classes/Service/AbstractService.php+1 −1
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/core/Classes/Utility/CommandUtility.php+4 −4
- typo3/sysext/core/Classes/Utility/DiffUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+4 −4
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+9 −9
- typo3/sysext/cshmanual/Classes/Controller/HelpModuleController.php+1 −1
- typo3/sysext/css_styled_content/Classes/Controller/CssStyledContentController.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+9 −9
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −2
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+2 −2
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+3 −3
- typo3/sysext/impexp/Classes/ImportExport.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/IndexedPagesController.php+3 −3
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+1 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+4 −4
- typo3/sysext/indexed_search/Classes/FileContentParser.php+2 −2
- typo3/sysext/indexed_search/Classes/Indexer.php+1 −1
- typo3/sysext/install/Classes/Service/SqlSchemaMigrationService.php+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+2 −2
- typo3/sysext/lowlevel/Classes/LostFilesCommand.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/Controller/SpellCheckingController.php+5 −5
- typo3/sysext/rtehtmlarea/Classes/Extension/Acronym.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/BlockElements.php+4 −4
- typo3/sysext/rtehtmlarea/Classes/Extension/ContextMenu.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/Extension/CopyPaste.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/DefinitionList.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Extension/InlineElements.php+4 −4
- typo3/sysext/rtehtmlarea/Classes/Extension/SelectFont.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php+3 −3
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaApi.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaBase.php+18 −18
- typo3/sysext/rtehtmlarea/Classes/SelectImage.php+3 −3
- typo3/sysext/sys_action/Classes/ActionTask.php+2 −2
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+2 −2
- typo3/sysext/workspaces/Classes/ExtDirect/ExtDirectServer.php+1 −1
Review log 12
-
Mr. Jenkins commented on patch set 1 07/24/13, 17:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9714/ : SUCCESS -
Markus Klein commented on patch set 1 V +1 CR +1 07/24/13, 17:32
DataHandler.php:1260Remove namespace here tooDataHandler.php:2943Namespace -
Markus Klein uploaded patch set 2 07/24/13, 17:36
-
Markus Klein voted on patch set 2 V +1 CR +1 07/24/13, 17:37
-
Mr. Jenkins commented on patch set 2 07/24/13, 17:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9715/ : SUCCESS -
Stefan Neufeind commented on patch set 2 CR -1 07/25/13, 20:56
In general a great idea. +1 But imho we should leave out cases where a certain elements are used. For example when you have a trimExplode() on a colon-separated string and feed that to list($a, $b) you expect the first two elements to be in there. And if you submitted value 'abc::def' you'll expect $b to be empty! -
Markus Klein commented on patch set 2 07/25/13, 23:35
@Stefan: I just don't understand your comment. Could you explain it for me once again please. ;-) -
Stefan Neufeind commented on patch set 2 07/25/13, 23:44
@Markus: When you have something like list($place, $menuEntry) = GeneralUtility::trimExplode(':', $pos, TRUE); That takes the first and second argument into variables. If you now use "TRUE" here as well, as the patch does in some places, the input-values "abc::def" will make a difference - because until now $menuEntry was empty (in this certain example) - and I guess that's what people will expect if they (might) intentionally write two separation-characters. Imho the cases you want to prevent by adding TRUE are just lists of elements like "abc,def,ghi" where one element might be empty (more precise: equal to '' after trimming) and should be left out. -
Markus Klein commented on patch set 2 07/26/13, 00:01
In which file do we have such a change? I saw only straight replacements of 1 <==> TRUE -
Stefan Neufeind commented on patch set 2 CR +1 07/26/13, 00:48
@Markus: You were right. Was too late already. -
Stefan Neufeind voted on patch set 2 V +2 CR +2 07/26/13, 10:14
-
Stefan Neufeind merged patch set 3 07/26/13, 10:14