Review main Merged

22551[FEATURE] Enable/disable cascading deletion of child elements

Christoph Niewerth CR +2 V +2 Normal +67 −20 updated 09/10/13, 07:15

Commit message

Deleting a record will also delete all child records,
which are configured as type inline (field, list) within.
This patch adds a behaviour configuration option "enableCascadingDelete"
which is by default treated as true. If set to FALSE or '' or 0
deletion of inline child records will be disabled.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
  • Verified V +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1

Issues 1

Files 2

Review log 18

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 07/25/13, 08:11

  2. Anja Leichsenring uploaded patch set 2 07/26/13, 20:00

  3. Mr. Jenkins commented on patch set 2 07/26/13, 20:01

  4. Anja Leichsenring commented on patch set 2 CR +1 07/26/13, 20:03

    Only adjusted the commit message slightly to humor Mr. Jenkins. Nice addition, thanks Niwi.
  5. Stefan Neufeind commented on patch set 2 CR +1 08/13/13, 21:59

    I'd appreciate a short testcase

    DataHandler.php:4529

    I don't like the negated check here too much. But of course it works.
  6. Anja Leichsenring uploaded patch set 3 09/09/13, 21:31

  7. Mr. Jenkins commented on patch set 3 09/09/13, 21:32

  8. Anja Leichsenring uploaded patch set 4 09/09/13, 21:33

  9. Anja Leichsenring commented on patch set 4 09/09/13, 21:33

    added a unit test.
  10. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/09/13, 21:33

  11. Mr. Jenkins commented on patch set 4 09/09/13, 21:33

  12. Stefan Neufeind commented on patch set 4 V +2 CR +2 09/09/13, 23:09

    Looks okay, works for me, linked doc-issue on forge exists.
  13. Stefan Neufeind merged patch set 5 09/09/13, 23:09

  14. Francois Suter commented on patch set 5 09/10/13, 06:15

    I don't see a corresponding documentation patch for this one, right or wrong?
  15. Francois Suter commented on patch set 5 09/10/13, 06:16

    Ah sorry, I was too fast, I just saw it now. But the relation was missing in the above commit message.
  16. Anja Leichsenring commented on patch set 5 09/10/13, 06:42

    Is there an entry now? How should I link the related documentation issue?
  17. Francois Suter commented on patch set 5 09/10/13, 06:49

    Yes it's fine. According to what we discussed at the T3ACME in Hamburg, the documentation issue should have been created upstream and reference in this commit message using "Documentation: #xxxxx".
  18. Anja Leichsenring commented on patch set 5 09/10/13, 07:15

    Sorry then, I did not remember. The ticket was there before, but only linked in forge. Room for improvement for me :)