22551[FEATURE] Enable/disable cascading deletion of child elements
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Anja Leichsenring +1
-
Verified V +2
- Stefan Neufeind +2
- Anja Leichsenring +1
Issues 1
Files 2
Review log 18
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 07/25/13, 08:11
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/9720/ : FAILURE -
Anja Leichsenring uploaded patch set 2 07/26/13, 20:00
-
Mr. Jenkins commented on patch set 2 07/26/13, 20:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9751/ : SUCCESS -
Anja Leichsenring commented on patch set 2 CR +1 07/26/13, 20:03
Only adjusted the commit message slightly to humor Mr. Jenkins. Nice addition, thanks Niwi. -
Stefan Neufeind commented on patch set 2 CR +1 08/13/13, 21:59
I'd appreciate a short testcaseDataHandler.php:4529I don't like the negated check here too much. But of course it works. -
Anja Leichsenring uploaded patch set 3 09/09/13, 21:31
-
Mr. Jenkins commented on patch set 3 09/09/13, 21:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10591/ : SUCCESS -
Anja Leichsenring uploaded patch set 4 09/09/13, 21:33
-
Anja Leichsenring commented on patch set 4 09/09/13, 21:33
added a unit test. -
Anja Leichsenring voted on patch set 4 V +1 CR +1 09/09/13, 21:33
-
Mr. Jenkins commented on patch set 4 09/09/13, 21:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10592/ : SUCCESS -
Stefan Neufeind commented on patch set 4 V +2 CR +2 09/09/13, 23:09
Looks okay, works for me, linked doc-issue on forge exists. -
Stefan Neufeind merged patch set 5 09/09/13, 23:09
-
Francois Suter commented on patch set 5 09/10/13, 06:15
I don't see a corresponding documentation patch for this one, right or wrong? -
Francois Suter commented on patch set 5 09/10/13, 06:16
Ah sorry, I was too fast, I just saw it now. But the relation was missing in the above commit message. -
Anja Leichsenring commented on patch set 5 09/10/13, 06:42
Is there an entry now? How should I link the related documentation issue? -
Francois Suter commented on patch set 5 09/10/13, 06:49
Yes it's fine. According to what we discussed at the T3ACME in Hamburg, the documentation issue should have been created upstream and reference in this commit message using "Documentation: #xxxxx". -
Anja Leichsenring commented on patch set 5 09/10/13, 07:15
Sorry then, I did not remember. The ticket was there before, but only linked in forge. Room for improvement for me :)