Review main Merged

22566[BUGFIX] require_once of vfsStream triggers travis fail

Christian Kuhn CR +2 V +2 Easy +7 −22 updated 07/25/13, 19:49

Commit message

vfsStream is now included in ext:phpunit, the pear module is
not maintained and was removed in travis.
This triggeres a failure in the phplint check. All require_once
calls are removed for now, ext:phpunit now also provides an
autoloader for vfsSstream.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jigal van Hemert +1
  • Verified V +2
    • Christian Kuhn +2
    • Jigal van Hemert +1

Issues 1

Files 9

Review log 7

  1. Christian Kuhn uploaded patch set 2 07/25/13, 18:46

  2. Mr. Jenkins commented on patch set 1 07/25/13, 18:46

  3. Mr. Jenkins commented on patch set 2 07/25/13, 18:48

  4. Jigal van Hemert commented on patch set 2 V +1 CR +1 07/25/13, 19:43

    Unit tests working again (no fatal errors because of missing vfsStream.php).
  5. Christian Kuhn voted on patch set 2 V +2 CR +2 07/25/13, 19:47

  6. Christian Kuhn merged patch set 3 07/25/13, 19:47

  7. Christian Kuhn commented on patch set 3 07/25/13, 19:49

    Cherry Picked This patchset was cherry picked to change: If1b07c31e999111e6b5d2804a9f5cc457066b7b0