Review main Merged

22572[BUGFIX] Improve method annotation and type hinting in FAL

Christian Kuhn CR +2 V +2 Easy +3 −2 updated 07/25/13, 20:58

Commit message

Add a missing "@throws" annotation and a namespaced comment.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 07/25/13, 20:57

  2. Christian Kuhn voted on patch set 1 V +2 CR +2 07/25/13, 20:58

  3. Christian Kuhn merged patch set 2 07/25/13, 20:58

  4. Christian Kuhn commented on patch set 2 07/25/13, 20:58

    Cherry Picked This patchset was cherry picked to change: Ibc929a01dbfdef9cf8730a8da259570786b6118c
  5. Christian Kuhn commented on patch set 2 07/25/13, 20:58

    Cherry Picked This patchset was cherry picked to change: Ibc929a01dbfdef9cf8730a8da259570786b6118c