22623[BUGFIX] concatenateCSS may produce invalid css
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Alexander Opitz +1
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2
- Stefan Neufeind +2
- Alexander Opitz +1
- Markus Klein +1
- Christian Kuhn +1
Issues 1
Files 2
Review log 23
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 07/27/13, 17:22
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/9761/ : FAILURE -
Thorben Nissen uploaded patch set 2 07/27/13, 17:25
-
Thorben Nissen uploaded patch set 3 07/27/13, 17:25
-
Mr. Jenkins commented on patch set 2 07/27/13, 17:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9762/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/27/13, 17:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9763/ : SUCCESS -
Wouter Wolters voted on patch set 3 CR +1 07/27/13, 17:28
-
Stefan Neufeind uploaded patch set 4 11/24/13, 22:14
-
Stefan Neufeind commented on patch set 4 11/24/13, 22:17
The previously proposed regex also failed in a quite basic case (import without quotes already in front). I've added testcases. Since the functionality introduces linefeeds (in the test visualised with LF) it's quite easy to see where breaks are inserted. This one comes with a proposal for a fixed regex. Imho we just need to search for everything which is not quotes or a round brace (without quotes before it). -
Mr. Jenkins commented on patch set 4 CR -1 V -1 11/24/13, 22:26
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/12310/ : FAILURE -
Stefan Neufeind updated the commit message in patch set 4 11/24/13, 22:30
-
Mr. Jenkins commented on patch set 5 11/24/13, 22:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12311/ : SUCCESS -
Markus Klein commented on patch set 5 11/25/13, 09:07
ResourceCompressorTest.php:57Why LF<space> here before body? -
Stefan Neufeind commented on patch set 5 11/25/13, 09:21
ResourceCompressorTest.php:57ReplyIt's based on the source (string), Luke :-) The url-line is cut out by a regex, moved to the front, that "head"-part is followed by an LF then an the rest is appended. We might consider adding a trim from the "rest"-part or so. But that's not critical in my eyes. (Feel free to tweak it further.) It works as expected and the regex works correct. Without the regex-adjustment you'll see that a LF was added after the #ffffff; - which caught my attention and showed that the regex worked incorrectly. Try it. -
Markus Klein commented on patch set 5 CR +1 11/25/13, 09:24
Thx for explanation. -
Stefan Neufeind commented on patch set 5 01/16/14, 23:14
please review -
Markus Klein commented on patch set 5 CR 0 01/16/14, 23:47
ResourceCompressor.php:652The single \ need another \ for proper PHP \ escaping -
Markus Klein uploaded patch set 6 03/05/14, 19:24
-
Markus Klein voted on patch set 6 V +1 CR +1 03/05/14, 19:24
-
Mr. Jenkins commented on patch set 6 03/05/14, 19:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14611/ : SUCCESS -
Alexander Opitz voted on patch set 6 V +1 CR +1 03/06/14, 07:23
-
Christian Kuhn voted on patch set 6 V +1 CR +1 03/06/14, 12:42
-
Stefan Neufeind commented on patch set 6 V +2 CR +2 03/06/14, 13:51
Looked at it again, and the new tests work fine for me. Imho let's have this. Thanks for all the reviews. -
Stefan Neufeind merged patch set 7 03/06/14, 13:51