Review main Merged

22632[BUGFIX] "New page" wizard discloses existence of pages outside DB mount

Nicole Hummel CR +2 V +2 Easy +9 −0 updated 02/07/14, 21:52

Commit message

When creating a new page inside the top level of a DB mount which is
only a sub tree, the pages up and down from the DB mount root will be
displayed in the position selector if the logged-in user has read
permissions for these pages. This is unwanted information disclosure as
the permissions should not matter for pages which are outside the DB
mount.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Marcin Sągol +1
    • Xavier Perseguers +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 2

Review log 18

  1. Mr. Jenkins commented on patch set 1 07/27/13, 21:15

  2. Nicole Hummel updated the commit message in patch set 1 10/22/13, 08:33

  3. Mr. Jenkins commented on patch set 2 10/22/13, 08:45

  4. Xavier Perseguers commented on patch set 2 10/22/13, 21:40

    AbstractTreeView.php:775

    euh... can't we use "early continue" instead of never ending if block?
  5. Xavier Perseguers uploaded patch set 3 11/23/13, 14:59

  6. Mr. Jenkins commented on patch set 3 11/23/13, 15:14

  7. Markus Klein rebased onto patch set 3 12/29/13, 14:17

  8. Markus Klein voted on patch set 4 CR +1 12/29/13, 14:18

  9. Mr. Jenkins commented on patch set 4 12/29/13, 14:31

  10. Xavier Perseguers voted on patch set 4 CR +1 12/29/13, 18:27

  11. Wouter Wolters voted on patch set 4 CR +1 02/05/14, 17:08

  12. Markus Klein commented on patch set 4 V +1 02/05/14, 17:37

    Works nicely!
  13. Stefan Neufeind voted on patch set 4 CR +1 02/07/14, 10:14

  14. Marcin Sągol voted on patch set 4 CR +1 02/07/14, 10:42

  15. Stefan Neufeind voted on patch set 4 V +2 CR +2 02/07/14, 21:52

  16. Stefan Neufeind merged patch set 5 02/07/14, 21:52

  17. Stefan Neufeind commented on patch set 5 02/07/14, 21:52

    Cherry Picked This patchset was cherry picked to change: I98008bc7f4308c9fb32dae645325e7cb1b44e413
  18. Stefan Neufeind commented on patch set 5 02/07/14, 21:52

    Cherry Picked This patchset was cherry picked to change: I98008bc7f4308c9fb32dae645325e7cb1b44e413