22655[!!!][TASK] Do not add JSON to header if type equals "json"
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Jan Helke +1
- Nicole Hummel +1
-
Verified V +2
- Benni Mack +2
- Jan Helke +1
- Nicole Hummel +1
Issues 1
Files 1
Review log 22
-
Mr. Jenkins commented on patch set 1 07/29/13, 09:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9793/ : SUCCESS -
Philipp Gampe commented on patch set 1 CR -1 07/29/13, 15:18
I disagree with the idea. Just sending a the Header an small payloads saves many bytes of data for a huge number of small AJAX requests. -
Stefan Neufeind commented on patch set 1 07/29/13, 16:13
About what magnitude do we speak? :-) Is data encoded (and thus enlarged) in one case and not the other or so? Would be great if we could back this up with details maybe. -
Philipp Gampe voted on patch set 1 CR 0 07/30/13, 09:59
-
Stefan Neufeind commented on patch set 1 07/30/13, 10:07
Is there anything that needs to be changed on the client-side? JavaScript might currently have taken data from the header I guess and now needs to be adjusted to look in the body instead?AjaxRequestHandler.php:270Do we need to add that header anyhow, if jsonhead is not set? The TRUE imho doesn't really make sense here.AjaxRequestHandler.php:272whoo ... it already was like that. So if you set "json" it would have been added to both header and body until now. -
Stefan Neufeind commented on patch set 1 CR -1 07/30/13, 20:37
Discussed with StefanF that another way might be to kind of "enforce" using jsonhead or jsonbody and to mark all other parameters passed to this function as "deprecated" usage (actually with a deprecation-entry). Otherwise we'd risk BC-breaking certain things. Currently if "json" is passed the values are sent both (!) in header and body, which obviously makes no sense. In the course of this bug it should then be investigated where core uses just 'json' as a parameter (hint: there are some cases). If we would prefer to "not abuse the headers" anymore, core could/should switch to jsonbody. Those parts that are adjusted then will need to be checked whether JS on clientside currently already makes use of the body-value or needs to be adapted as well. So unfortunately this cleanup will be a bit larger task - but imho it's worth it. Currently transfering the data twice if used wrong is really no option! -
Stefan Neufeind commented on patch set 1 08/04/13, 22:29
@Stefan (well, or others): Could you look into this again, please? -
Stefan Froemken commented on patch set 1 08/29/14, 05:57
And again. I would prefer to change that to jsonbody as default: https://devcentral.f5.com/articles/ruby-developers-ignore-security-risks-claim-x-json-header-lsquonothing-serious-rsquo and remove all X-JSON headers -
Stefan Froemken commented on patch set 1 08/29/14, 06:00
AjaxRequestHandler.php:270ReplyWe don't need it here and anywhere else in TYPO3-codeAjaxRequestHandler.php:272ReplyFunny, right? The default behaviour doesn't make sense. So please let us change it to jsonbody as default. -
Stefan Froemken uploaded patch set 2 08/29/14, 06:18
-
Stefan Froemken uploaded patch set 3 08/29/14, 06:19
-
Benni Mack uploaded patch set 4 01/07/15, 18:43
-
Benni Mack voted on patch set 4 CR +1 01/07/15, 18:43
-
Stefan Neufeind commented on patch set 4 CR +1 01/07/15, 23:57
I'm fine with the change. As pointed out by !!! in the commit-msg this needs some kind of "warning" in the release-notes. Do we add rst-files for that as well? -
Benni Mack commented on patch set 4 01/08/15, 12:04
I think we should drop / deprecate jsonhead and jsonbody as well as the charset issues (not needed anymore) in a followup (= once prototype is definitively not included at all anymore) -
Benni Mack uploaded patch set 5 03/22/15, 23:44
-
Nicole Hummel voted on patch set 5 CR +1 03/23/15, 13:12
-
Nicole Hummel voted on patch set 5 V +1 03/23/15, 13:19
-
Stefan Neufeind voted on patch set 5 CR +1 03/23/15, 13:24
-
Jan Helke voted on patch set 5 CR +1 V +1 03/23/15, 14:17
-
Benni Mack voted on patch set 5 CR +2 V +2 03/23/15, 14:18
-
Benni Mack merged patch set 5 03/23/15, 14:18