22657[BUGFIX] Fix fatal error in extension manager
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Tomita Militaru +1
-
Verified V +2
- Wouter Wolters +2
- Tomita Militaru +1
Issues 1
Files 1
Review log 9
-
Tomita Militaru commented on patch set 1 V -1 08/01/13, 13:16
After applying the patch I get now multiple warnings in 4.7.1: Warning: array_keys() expects parameter 1 to be array, string given in D:\project\typo3\sysext\em\classes\tools\class.tx_em_tools.php on line 388 Warning: implode() [function.implode]: Invalid arguments passed in D:\project\typo3\sysext\em\classes\tools\class.tx_em_tools.php on line 388 Warning: array_keys() expects parameter 1 to be array, string given in D:\project\typo3\sysext\em\classes\tools\class.tx_em_tools.php on line 388 -
Michael Stucki commented on patch set 1 08/01/13, 14:34
Hi Tomita, are you sure about your findings? Please use a more recent version to verify it - 4.7.1 is pretty old nowadays. The code which is added is a 1:1 backport from the master branch. Compare it with typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php. Greetings, Michael -
Tomita Militaru commented on patch set 1 08/01/13, 14:39
Sorry about the typo, I meant to say TYPO3 4.7.14 -
Michael Stucki commented on patch set 1 08/01/13, 15:12
Still I'd like you to investigate the issue. Otherwise it means that the same error happens in TYPO3 6.1 too. Can you check that? -
Philipp Gampe commented on patch set 1 08/02/13, 11:59
@Timita I think you did something wrong while applying the patch. From the code, it is impossible to get your error messages, because the code is only executed if it is an array (thus it cannot be a string) and if the array actually contains elements. -
Tomita Militaru commented on patch set 1 V +1 CR +1 08/02/13, 12:52
Hello, I've tested on 2 clean installations of 4.7.14 and 4.5.29 and indeed it works just fine. Sorry, my bad, but not sure why I had that problem. -
Wouter Wolters voted on patch set 1 V +2 CR +2 08/03/13, 11:48
-
Wouter Wolters merged patch set 2 08/03/13, 11:48
-
Michael Stucki commented on patch set 2 08/05/13, 07:54
Thanks Wouter!