Review main Merged

22682[BUGFIX] Query parameters of external link may get altered

Stanislas Rolland CR +2 V +2 Easy +5 −1 updated 08/17/13, 16:32

Commit message

If an external link is set to the same domain as the BE domain and
the id query parameter is present, any other query parameters will
be altered (and repeated).
Solution: href of external link should remain unaltered.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Wouter Wolters +1
  • Verified V +2
    • Philipp Gampe +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 07/30/13, 02:36

  2. Philipp Gampe commented on patch set 1 07/30/13, 09:53

    Same as https://review.typo3.org/#/c/22683/ please abandon either one
  3. Wouter Wolters voted on patch set 1 V +1 CR +1 08/12/13, 17:53

  4. Philipp Gampe voted on patch set 1 CR +1 08/17/13, 16:25

  5. Philipp Gampe commented on patch set 1 V +2 CR +2 08/17/13, 16:31

    verified, this is ugly as the "wrong" href is actually saved inside the RTE field
  6. Philipp Gampe merged patch set 2 08/17/13, 16:31

  7. Philipp Gampe commented on patch set 2 08/17/13, 16:32

    Cherry Picked This patchset was cherry picked to change: I79564ebf63ee4f92bfd3f95b17f72592ea849163