Review main Merged Breaking

2269[FEATURE][CONF][!!!] Deprecate PHP_SCRIPT* objects

Francois Suter CR +2 V +2 Easy +15 −0 updated 06/03/13, 20:49

Commit message

PHP_SCRIPT, PHP_SCRIPT_INT and PHP_SCRIPT_EXT objects are old
TypoScript content objects which really shouldn't be used anymore.
Mark them as deprecated.

Review

  • Code review CR +2
    • Francois Suter +2
    • Chris topher +1
    • Xavier Perseguers +1
    • Philipp Gampe +1
  • Verified V +2
    • Francois Suter +2
    • Chris topher +1
    • Philipp Gampe +1

Issues 1

Files 3

Review log 11

  1. Francois Suter uploaded patch set 2 05/22/11, 12:11

  2. Francois Suter commented on patch set 2 05/22/11, 12:11

    Moved the @deprecated comment. I wasn't really sure about where to place it, but I'm fine with having it on the method.
  3. Xavier Perseguers commented on patch set 1 05/22/11, 12:11

    Looks good to me, but someone else must approve I'd like to see the @deprecated comment for the method itself instead
  4. Xavier Perseguers commented on patch set 2 05/22/11, 12:11

    Looks good to me, but someone else must approve
  5. Chris topher commented on patch set 1 05/22/11, 12:11

    Verified; Looks good to me, but someone else must approve
  6. Chris topher commented on patch set 2 05/22/11, 12:11

    Verified; Looks good to me, but someone else must approve
  7. Philipp Gampe commented on patch set 2 05/22/11, 12:11

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 05/22/11, 12:11

  9. Mr. Jenkins commented on patch set 2 05/22/11, 12:11

  10. Francois Suter commented on patch set 2 V 0 05/22/11, 12:11

    by team member; Looks good to me, approved
  11. Francois Suter merged patch set 2 05/22/11, 12:11