Review main Merged

22724[BUGFIX] Ignore case in file extension filter

Alexander Stehlik CR +2 V +2 Normal +59 −9 updated 08/07/13, 18:07

Commit message

This patch makes the FileExtensionFilter case insensitive.

If the filter is configured to allow files with the ".EXT"
extension it will now also allow files with an ".ext"
extension.

Additionally the order of a data provider method in the
FileExtensionFilterTest has been corrected.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1

Issues 1

Files 2

Review log 18

  1. Mr. Jenkins commented on patch set 1 07/30/13, 16:13

  2. Alexander Stehlik uploaded patch set 2 07/30/13, 16:16

  3. Mr. Jenkins commented on patch set 2 07/30/13, 16:16

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/30/13, 16:34

  5. Stefan Neufeind commented on patch set 2 CR -1 07/30/13, 20:30

    FileExtensionFilter.php:169

    in general okay, but from method-name imho outside the scope of this method
  6. Alexander Stehlik commented on patch set 2 07/31/13, 16:33

    @Stefan: Should is rename the method? Since it is no public API it should not be a problem. Any suggestions? Maybe initializeExtensionList() ?
  7. Anja Leichsenring uploaded patch set 3 08/03/13, 13:41

  8. Mr. Jenkins commented on patch set 3 08/03/13, 13:42

  9. Stefan Neufeind commented on patch set 3 V +1 CR +1 08/03/13, 15:56

    FileExtensionFilterTest.php:137

    I think we usually have the dataproviders in front of the functions. But I don't really mind ...
  10. Alexander Stehlik uploaded patch set 4 08/03/13, 18:14

  11. Alexander Stehlik commented on patch set 4 08/03/13, 18:15

    Updated method name und fixed order of data providers in unit tests :)
  12. Mr. Jenkins commented on patch set 4 08/03/13, 18:15

  13. Alexander Stehlik commented on patch set 4 08/03/13, 18:18

    I just realized that the namespace for the unit test is wrong: At the moment it is TYPO3\CMS\Core\Tests\Unit\Resource\Utility but the class that is tested is in TYPO3\CMS\Core\Resource\Filter Can I move it with this change or should I open a new issue on forge for that?
  14. Stefan Neufeind commented on patch set 4 V +1 CR +1 08/03/13, 21:41

    I'd do the move/namespace-change in a separate push (type "task" maybe). I'm sure we can take care of that without too much buerocracy :-)
  15. Wouter Wolters voted on patch set 4 V +2 CR +2 08/07/13, 18:07

  16. Wouter Wolters merged patch set 5 08/07/13, 18:07

  17. Wouter Wolters commented on patch set 5 08/07/13, 18:07

    Cherry Picked This patchset was cherry picked to change: I5761ab7f06116ef847caeb2ae786e580730c0e6b
  18. Wouter Wolters commented on patch set 5 08/07/13, 18:07

    Cherry Picked This patchset was cherry picked to change: I5761ab7f06116ef847caeb2ae786e580730c0e6b