Review main Abandoned

22725[BUGFIX] Allow @ Character for Filenames

Lucas Bremgartner CR 0 V 0 Normal +212 −1 updated 02/24/14, 22:48

Commit message

Replace [:alnum:] with 0-9A-Za-z in regex, escaping for . and -
[:alnum:] breaks tests with utf-8 strings and leads
to utf-8 sequence EF BF BD (replacement character).
Unit tests are added for BasicFileUtility.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 18

  1. Mr. Jenkins commented on patch set 1 07/30/13, 21:21

  2. Stefan Neufeind commented on patch set 1 CR -1 07/31/13, 23:45

    Imho for the 7-bit ASCII (0-127), which are identical in latin1 and utf8, we should agree on a common solution which chars are allowed. Charset-table to help: https://de.wikipedia.org/wiki/ISO_8859-1
    leave out "LTS" here (can be done upon merge)
  3. Lucas Bremgartner commented on patch set 1 08/08/13, 21:00

    @Stefan Neufeind: I agree with you, for the 7-bit ASCII (0-127) the same characters should be allowed in both cases (latin1 and utf8). I checked again. With the @ sign added for latin1, the two cases do allow the same characters for filenames for 0 - 127. Could you please explain your -1 a little bit more. Thank you.
  4. Stefan Neufeind commented on patch set 1 08/09/13, 10:01

    One list is a blacklist of characters, the other a whitelist. And the two are separate. So I thought we might want to: * choose to either black- or whitelist for all cases * have one central list for 7-bit-ASCII * look closer into what characters we want to allow or which we (need to?) disallow Thanks for taking care of this topic.
  5. Lucas Bremgartner commented on patch set 1 08/29/13, 14:02

    I have added some unit tests and a consolidated regex in https://review.typo3.org/#/c/23439/
  6. Lucas Bremgartner uploaded patch set 2 08/29/13, 19:40

  7. Mr. Jenkins commented on patch set 2 08/29/13, 19:43

  8. Philipp Gampe commented on patch set 2 08/31/13, 17:09

    Please consolidate your changes into one or two change requests. You can have a look at your open changes at: https://review.typo3.org/#/q/owner:lb%2540bexa.ch+status:open,n,z It is currently a bit unclear to me, what patches are needed and in what order they should be committed.
  9. Stefan Neufeind commented on patch set 2 08/31/13, 23:29

    If https://review.typo3.org/#/c/23439/ is integrated, that (consolidating regex) will also take care of adding the @-character as well. So in that case, this one would become obsolte. Both patches are indepedent of each other - maybe imho with a preference to clarify the unification of regex for (non-)unicode.
  10. Lucas Bremgartner uploaded patch set 3 09/01/13, 20:38

  11. Mr. Jenkins commented on patch set 3 09/01/13, 20:39

  12. Lucas Bremgartner commented on patch set 3 09/01/13, 20:51

    I abandoned the change https://review.typo3.org/#/c/23436/ and pushed the modifications to this change as patchset. This change now includes the new unit-tests, the @-char and the replacement of [:alnum:] because this breaks with utf-8 string. The consolidation of the regular expression for utf-8 and non utf-8 filesystems suggested by Stefan Neufeind is placed in change https://review.typo3.org/#/c/23439/. Now it is up to you to decide, if the regular expressions should be consolidated or if the should left independent. I hope this clears things up and I apologize for the mess I created with git/gerrit due to lack of specific knowledge.
  13. Markus Klein uploaded patch set 4 01/16/14, 22:52

  14. Mr. Jenkins commented on patch set 4 CR -1 V -1 01/16/14, 23:13

  15. Markus Klein commented on patch set 4 01/16/14, 23:51

    BasicFileUtilityTest.php:66

    CGL not observed for all for loops
  16. Oliver Klee commented on patch set 4 01/17/14, 08:18

    BasicFileUtilityTest.php:49

    If those three fields are @array, they need to have empty arrays as default values, not empty strings.

    BasicFileUtilityTest.php:54

    Char -> Character

    BasicFileUtilityTest.php:73

    @return is missing.
  17. Stefan Neufeind commented on patch set 4 01/17/14, 08:42

    imho better the consolidated alternative at https://review.typo3.org/#/c/23439/ instead. Maybe also review over there.
  18. Markus Klein abandoned the change 02/24/14, 22:48

    Will be solved with https://review.typo3.org/23439 Test cases are transferred there already.