Review main Merged

22726[BUGFIX] Reports module tries to load not-installed extension

Wouter Wolters CR +2 V +2 Easy +16 −1 updated 08/08/13, 21:06

Commit message

When you select a report from an extension, the reports module
will remember this when you re-open it. But if you have
uninstalled the extension in the meantime, the reports module
will throw an exception. This is fixed by checking the
$reportClass. If this is NULL then redirect to indexAction.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 07/30/13, 22:33

  2. Stefan Neufeind commented on patch set 1 CR -1 07/30/13, 22:55

    Imho we should cleanly check for existance. I expect PHP might at least log a notice since the code tries to access sub-arrays of a no longer loaded extension.
  3. Philipp Gampe commented on patch set 1 07/31/13, 07:13

    I agree with Stefan, we should check for array key existence too. I guess this is a longer list of conditions then.
    installed
  4. Chris topher updated the commit message in patch set 1 07/31/13, 08:36

  5. Mr. Jenkins commented on patch set 2 07/31/13, 08:37

  6. Dmitry Dulepov commented on patch set 2 CR -1 07/31/13, 12:56

    The right way would be to use \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::isLoaded($extension).
  7. Wouter Wolters commented on patch set 2 07/31/13, 13:08

    No that is not the way to go here. The $extension variable does not contain the extensionname. but a chosen name by the developer.
  8. Wouter Wolters uploaded patch set 3 07/31/13, 19:09

  9. Mr. Jenkins commented on patch set 3 07/31/13, 19:10

  10. Stefan Neufeind commented on patch set 3 CR +1 07/31/13, 20:11

    I thought we could leave out one or two isset in there. But it doesn't seem so (tested in a small example locally) without risking to throw a notice.
  11. Christian Kuhn voted on patch set 3 V +1 CR +1 08/08/13, 19:54

  12. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/08/13, 21:03

  13. Anja Leichsenring merged patch set 4 08/08/13, 21:03

  14. Anja Leichsenring commented on patch set 4 08/08/13, 21:06

    Cherry Picked This patchset was cherry picked to change: Ifad4e6ee8dc651a3d6b1360486fd5a7cb2abf111