22734[BUGFIX] Language-module icons need to display in correct size
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Philipp Gampe +1
-
Verified V +2
- Anja Leichsenring +2
- Philipp Gampe +1
Issues 1
Files 3
Review log 12
-
Mr. Jenkins commented on patch set 1 07/31/13, 14:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9859/ : SUCCESS -
Stefan Neufeind commented on patch set 1 07/31/13, 14:17
How to test: Manually set span for the icon to class="stateIconChecking". That's what JavaScript sets it to when moving through the list. This patch adds class "stateIcon" as a common ground (we could also use the central span.t3-icon or the like; but this one is already module-specific). And then stateIcon is added to all occurrences of any state-icons so they render correctly as inline-block (taking into account their specified width/height). -
Philipp Gampe commented on patch set 1 V -1 08/17/13, 22:23
This results in a missing icon (question mark in red cycle). -
Philipp Gampe commented on patch set 1 CR -1 08/17/13, 22:23
The class should be added inside the viewhelper. -
Philipp Gampe uploaded patch set 2 08/18/13, 09:13
-
Mr. Jenkins commented on patch set 2 08/18/13, 09:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10119/ : SUCCESS -
Philipp Gampe updated the commit message in patch set 2 08/18/13, 09:18
-
Philipp Gampe voted on patch set 3 V +1 CR +1 08/18/13, 09:18
-
Mr. Jenkins commented on patch set 3 08/18/13, 09:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/10120/ : SUCCESS -
Anja Leichsenring voted on patch set 3 V +2 CR +2 08/18/13, 12:17
-
Anja Leichsenring merged patch set 4 08/18/13, 12:17
-
Anja Leichsenring commented on patch set 4 08/18/13, 12:17
Cherry Picked This patchset was cherry picked to change: I5ba318e6a3ca4602714d0c4b5f12674e2e305952