Review main Merged

22734[BUGFIX] Language-module icons need to display in correct size

Stefan Neufeind CR +2 V +2 Easy +15 −11 updated 08/18/13, 12:17

Commit message

Since inline:display-block was missing on those icons, those
icons didn't display in their intended size although they
had a width/height-attribute set.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Philipp Gampe +1
  • Verified V +2
    • Anja Leichsenring +2
    • Philipp Gampe +1

Issues 1

Files 3

Review log 12

  1. Mr. Jenkins commented on patch set 1 07/31/13, 14:11

  2. Stefan Neufeind commented on patch set 1 07/31/13, 14:17

    How to test: Manually set span for the icon to class="stateIconChecking". That's what JavaScript sets it to when moving through the list. This patch adds class "stateIcon" as a common ground (we could also use the central span.t3-icon or the like; but this one is already module-specific). And then stateIcon is added to all occurrences of any state-icons so they render correctly as inline-block (taking into account their specified width/height).
  3. Philipp Gampe commented on patch set 1 V -1 08/17/13, 22:23

    This results in a missing icon (question mark in red cycle).
  4. Philipp Gampe commented on patch set 1 CR -1 08/17/13, 22:23

    The class should be added inside the viewhelper.
  5. Philipp Gampe uploaded patch set 2 08/18/13, 09:13

  6. Mr. Jenkins commented on patch set 2 08/18/13, 09:14

  7. Philipp Gampe updated the commit message in patch set 2 08/18/13, 09:18

  8. Philipp Gampe voted on patch set 3 V +1 CR +1 08/18/13, 09:18

  9. Mr. Jenkins commented on patch set 3 08/18/13, 09:18

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/18/13, 12:17

  11. Anja Leichsenring merged patch set 4 08/18/13, 12:17

  12. Anja Leichsenring commented on patch set 4 08/18/13, 12:17

    Cherry Picked This patchset was cherry picked to change: I5ba318e6a3ca4602714d0c4b5f12674e2e305952